[jira] [Commented] (WICKET-5539) Incorrect recreation of page in case of PageExpire

["Guillaume Smet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090719#comment-14090719 ] 

Guillaume Smet commented on WICKET-5539:
----------------------------------------

Hi Martin,

My 2 cents: I really think we should stay with only the parameters of the initial request. It's far more predictive. Combining the parameters might lead to unexpected results.

If the page is expired, being redirected to the exact same page again is OK AFAICS. Maybe, we should even consider adding a warning message in the session or provide a way to do so as it's still a bit surprising for the user.

IIRC there was a project to have 2 sorts of parameters in 7. Is it still in the way? I must admit I was too busy these last months to keep an eye on 7 development.

-- 
Guillaume

> Incorrect recreation of page in case of PageExpire
> --------------------------------------------------
>
>                 Key: WICKET-5539
>                 URL: https://issues.apache.org/jira/browse/WICKET-5539
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.14.0
>            Reporter: Ilia Naryzhny
>            Assignee: Martin Grigorov
>              Labels: expiration, mountBookmarkablePage
>             Fix For: 6.17.0
>
>         Attachments: wicket5539.zip
>
>
> There is a bookmarkable page mounted, for example, to:
> /page/${entityId}
> This page contains StatelessForm.
> Submitting of form after session expire lead to following:
> org.apache.wicket.core.request.mapper.MountedMapper invokes AbstractBookmarkableMapper.processListener to obtain IRequestHandler to handle submitting of form. 
> But there is cleaning of PageParameters within processListener on line 256 (Wicket 6.14) which cleaning "entityId" parameter as well and created page finally has no "enityId" and (in our case) redirects to 404.
> I see that this cleaning of page parameters was implemented due to Wicket-4594. But I think, just checking for pageId is unsufficient, because pageId might be not null, but actual page may be already expired and new instance should be created.



--
This message was sent by Atlassian JIRA
(v6.2#6252)