You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Randgalt <gi...@git.apache.org> on 2016/09/28 08:35:50 UTC
[GitHub] zookeeper pull request #82: [ZOOKEEPER-2169] Enable creation of nodes with T...
GitHub user Randgalt opened a pull request:
https://github.com/apache/zookeeper/pull/82
[ZOOKEEPER-2169] Enable creation of nodes with TTLs
This patch takes advantage of 3.5's container support. Most of the work needed to support TTLs is there already.
In order not to break on-disk and protocol compatibility the ephemeralOwner is yet-again overloaded to have special meaning.
New opcodes and transaction records had to be added in a similar manner to Containers
NOTE: This patch was originally in Review Board and was moved to Github for ease/convenience. RB link:
https://reviews.apache.org/r/46983/#comment214810
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2169
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit 9cb973c7ff77b9a12c2fb74d05da38b79ab34c07
Author: randgalt <jo...@jordanzimmerman.com>
Date: 2016-09-28T08:32:50Z
This patch takes advantage of 3.5's container support. Most of the work needed to support TTLs is there already.
In order not to break on-disk and protocol compatibility the ephemeralOwner is yet-again overloaded to have special meaning.
New opcodes and transaction records had to be added in a similar manner to Containers
NOTE: This patch was originally in Review Board and was moved to Github for ease/convenience. RB link:
https://reviews.apache.org/r/46983/#comment214810
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #82: [ZOOKEEPER-2169] Enable creation of nodes with TTLs
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/82
Yeah - in other projects a merge autocloses these. Dunno why this didn't.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #82: [ZOOKEEPER-2169] Enable creation of nodes with TTLs
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/82
@skamille @Randgalt Wasn't this issue resolved? We can close this PR it by now, right? :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #82: [ZOOKEEPER-2169] Enable creation of nodes with TTLs
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/82
@Randgalt Oh, we are putting the finishing touches in the JIRA-Github-Apache integration & workflow, so any of the scripts that hold things together missed this one. We are still debugging the integration. :cactus:
Also, the PR title should start with the JIRA id, but without the square brackets (AFAIK): ``ZOOKEEPER-2169:`` instead of ``[ZOOKEEPER-2169] ``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #82: [ZOOKEEPER-2169] Enable creation of nodes with TTLs
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/82
I never had to write any scripts so I really can't say. It all "just worked". But, then, Curator started as a git project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #82: [ZOOKEEPER-2169] Enable creation of nodes with TTLs
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/82
On Curator I always use the [] and it works. �\_(\u30c4)_/�
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #82: [ZOOKEEPER-2169] Enable creation of nodes with T...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt closed the pull request at:
https://github.com/apache/zookeeper/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #82: [ZOOKEEPER-2169] Enable creation of nodes with TTLs
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/82
**Very cool!** :smiley: Excuse me, totally forgot that Curator has been using Github + Apache integration well before. Please, if you have some spare cycles, it would be really cool if you could provide us some feedback/opinion on this migration. The discussion threads, that are remember from heart, are the ones below:
* [VOTE] move Apache Zookeeper to git
* QA github pre-commit queue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---