[GitHub] guacamole-client pull request #313: GUACAMOLE-598: Show fatal error message ...

[mike-jumper <gi...@git.apache.org>]

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-client/pull/313

    GUACAMOLE-598: Show fatal error message only after a fatal error has occurred.

    As the fatal error message is selectively hidden using AngularJS, there is a moment before AngularJS has loaded during which the error message may be visible even though no error has occurred.
    
    These changes alter the styling of the error such that it is always hidden by default, even before AngularJS kicks in. This is the same technique used to ensure that a mangled status notification dialog doesn't flash into view while the application is loading.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-client hide-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-client/pull/313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #313
    
----
commit 0cc5c3667b747d58850c0edf09f1ed9fdf76e692
Author: Michael Jumper <mj...@...>
Date:   2018-09-07T20:37:06Z

    GUACAMOLE-598: Ensure fatal error message is hidden by default, shown only when a fatal error has actually occurred.

----


---

[GitHub] guacamole-client pull request #313: GUACAMOLE-598: Show fatal error message ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/guacamole-client/pull/313


---