[GitHub] [pulsar] codelipenghui commented on a change in pull request #10653: [Transaction] Transaction admin api get coordinator internal stats.

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #10653:
URL: https://github.com/apache/pulsar/pull/10653#discussion_r640423511



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/CoordinatorInternalStats.java
##########
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.common.policies.data;
+
+/**
+ * Transaction coordinator internal stats.
+ */
+public class CoordinatorInternalStats {
+
+    /** The manage ledger internal stats*/
+    public ManagedLedgerInternalStats managedLedgerInternalStats;

Review comment:
       ```suggestion
       public ManagedLedgerInternalStats txnLogInternalStats;
   ```

##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/CoordinatorInternalStats.java
##########
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.common.policies.data;
+
+/**
+ * Transaction coordinator internal stats.
+ */
+public class CoordinatorInternalStats {
+
+    /** The manage ledger internal stats*/
+    public ManagedLedgerInternalStats managedLedgerInternalStats;

Review comment:
       We also need to expose the managed ledger name? Since we can't get the managed ledger name from the `ManagedLedgerInternalStats `




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org