You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/22 02:44:29 UTC

[GitHub] [shardingsphere] sharpzhango opened a new pull request #8279: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

sharpzhango opened a new pull request #8279:
URL: https://github.com/apache/shardingsphere/pull/8279


   Fixes #8241 .
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #8279: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #8279:
URL: https://github.com/apache/shardingsphere/pull/8279#issuecomment-731716963


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8279?src=pr&el=h1) Report
   > Merging [#8279](https://codecov.io/gh/apache/shardingsphere/pull/8279?src=pr&el=desc) (8263008) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a07d5c4e96f4ee1eea91a6a58b4adf3541ac0750?el=desc) (a07d5c4) will **increase** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8279/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8279?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8279      +/-   ##
   ============================================
   + Coverage     74.72%   74.76%   +0.04%     
   - Complexity      600      603       +3     
   ============================================
     Files          1483     1495      +12     
     Lines         23435    23563     +128     
     Branches       4174     4190      +16     
   ============================================
   + Hits          17512    17618     +106     
   - Misses         4772     4790      +18     
   - Partials       1151     1155       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8279?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../text/sctl/show/ShardingCTLShowBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3NjdGwvc2hvdy9TaGFyZGluZ0NUTFNob3dCYWNrZW5kSGFuZGxlci5qYXZh) | `86.66% <ø> (+5.41%)` | `0.00 <0.00> (ø)` | |
   | [...e/infra/executor/sql/query/raw/RawQueryResult.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9xdWVyeS9yYXcvUmF3UXVlcnlSZXN1bHQuamF2YQ==) | | | |
   | [...executor/sql/query/jdbc/MemoryJDBCQueryResult.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9xdWVyeS9qZGJjL01lbW9yeUpEQkNRdWVyeVJlc3VsdC5qYXZh) | | | |
   | [...executor/sql/query/jdbc/StreamJDBCQueryResult.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9xdWVyeS9qZGJjL1N0cmVhbUpEQkNRdWVyeVJlc3VsdC5qYXZh) | | | |
   | [...ecutor/sql/query/jdbc/AbstractJDBCQueryResult.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9xdWVyeS9qZGJjL0Fic3RyYWN0SkRCQ1F1ZXJ5UmVzdWx0LmphdmE=) | | | |
   | [.../jdbc/PreparedStatementExecutionPrepareEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcmVwYXJlL2RyaXZlci9qZGJjL1ByZXBhcmVkU3RhdGVtZW50RXhlY3V0aW9uUHJlcGFyZUVuZ2luZS5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
   | [...l/execute/raw/callback/RawSQLExecutorCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL3Jhdy9jYWxsYmFjay9SYXdTUUxFeGVjdXRvckNhbGxiYWNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...e/driver/jdbc/impl/DefaultSQLExecutorCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL2RyaXZlci9qZGJjL2ltcGwvRGVmYXVsdFNRTEV4ZWN1dG9yQ2FsbGJhY2suamF2YQ==) | `83.33% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...cutor/sql/result/jdbc/AbstractJDBCQueryResult.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9yZXN1bHQvamRiYy9BYnN0cmFjdEpEQkNRdWVyeVJlc3VsdC5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...nfra/executor/sql/execute/raw/RawJDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL3Jhdy9SYXdKREJDRXhlY3V0b3IuamF2YQ==) | `87.50% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/8279/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8279?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8279?src=pr&el=footer). Last update [a07d5c4...8263008](https://codecov.io/gh/apache/shardingsphere/pull/8279?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sharpzhango commented on pull request #8279: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.

sharpzhango commented on pull request #8279:
URL: https://github.com/apache/shardingsphere/pull/8279#issuecomment-731699160


   ok，I will try 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #8279: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.

terrymanu merged pull request #8279:
URL: https://github.com/apache/shardingsphere/pull/8279


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sharpzhango commented on pull request #8279: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.

sharpzhango commented on pull request #8279:
URL: https://github.com/apache/shardingsphere/pull/8279#issuecomment-731692424


   > Can you fix the compile error?
   
   I didn't modify pom.xml, why did it go wrong?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #8279: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.

terrymanu commented on pull request #8279:
URL: https://github.com/apache/shardingsphere/pull/8279#issuecomment-731698246


   Compile error, can you execute `mvn install` in your local env and debug it first?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org