[GitHub] [helix] i3wangyi commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

[GitBox <gi...@apache.org>]

i3wangyi commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer
URL: https://github.com/apache/helix/pull/341#issuecomment-512928626
 
 
   I'm not that worried about checking in a bunch of commits into a separate branch. Given that
   - The change here is known for its incompleteness/buggy/less optimized, etc, but it just functions basically like the foundation piece 
   - A lot of re-write works is needed. We will and need to work together to rewrite almost every component of it. Rewrite naturally gives us a chance to review the code once again.
   - Once re-write is completed and it's in a good shape, we still have a pretty good chance to re-organize the commits and merge back to the master
   
   Given the current giant change, it would rely too much on Jiajun's single effort to make the splits (splits usually are non-trivial) and it's not going to move fast. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services