You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Rodrigo (JIRA)" <ji...@apache.org> on 2009/02/26 10:03:01 UTC

[jira] Created: (WICKET-2128) StringValidator error messages erroneously mention input instead of label

StringValidator error messages erroneously mention input instead of label
-------------------------------------------------------------------------

                 Key: WICKET-2128
                 URL: https://issues.apache.org/jira/browse/WICKET-2128
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.4-RC2
         Environment: any
            Reporter: Rodrigo
            Priority: Minor


Using a StringValidator.MaximumLengthValidator (or any flavor of the StringValidator class), the reported errors are currently under the form:
StringValidator.minimum='${input}' is shorter than the minimum of ${minimum} characters.

which creates odd messages where the content of the field is mentionned instead of the field label.
Example:
* 'Joe' is shorter than the minimum of 5 characters.
should be
* The field 'Name' should be at least 5 characters long

This is specially important in password fields, where the StringValidator is not usable because it displays the input in clear text on the web page:

* 'x4eR4*z' is shorter than the minimum of 5 characters.
should be
* The field 'Password' should be at least 5 characters long



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2128) StringValidator error messages erroneously mention input instead of label

Posted by "Rodrigo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676942#action_12676942 ] 

Rodrigo commented on WICKET-2128:
---------------------------------

Just another comment: it also happens that the user writes the same thing in different fields. For instance in "login" and "first name" fields, in such cases, the ${input} reference is ambiguous, and ${label} should be used instead.

> StringValidator error messages erroneously mention input instead of label
> -------------------------------------------------------------------------
>
>                 Key: WICKET-2128
>                 URL: https://issues.apache.org/jira/browse/WICKET-2128
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC2
>         Environment: any
>            Reporter: Rodrigo
>            Priority: Minor
>
> Using a StringValidator.MaximumLengthValidator (or any flavor of the StringValidator class), the reported errors are currently under the form:
> StringValidator.minimum='${input}' is shorter than the minimum of ${minimum} characters.
> which creates odd messages where the content of the field is mentionned instead of the field label.
> Example:
> * 'Joe' is shorter than the minimum of 5 characters.
> should be
> * The field 'Name' should be at least 5 characters long
> This is specially important in password fields, where the StringValidator is not usable because it displays the input in clear text on the web page:
> * 'x4eR4*z' is shorter than the minimum of 5 characters.
> should be
> * The field 'Password' should be at least 5 characters long

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2128) StringValidator error messages erroneously mention input instead of label

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-2128:
----------------------------------

    Fix Version/s: 1.5-M3
                       (was: 1.5-M2)

> StringValidator error messages erroneously mention input instead of label
> -------------------------------------------------------------------------
>
>                 Key: WICKET-2128
>                 URL: https://issues.apache.org/jira/browse/WICKET-2128
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC2
>         Environment: any
>            Reporter: Rodrigo
>            Priority: Minor
>             Fix For: 1.5-M3
>
>
> Using a StringValidator.MaximumLengthValidator (or any flavor of the StringValidator class), the reported errors are currently under the form:
> StringValidator.minimum='${input}' is shorter than the minimum of ${minimum} characters.
> which creates odd messages where the content of the field is mentionned instead of the field label.
> Example:
> * 'Joe' is shorter than the minimum of 5 characters.
> should be
> * The field 'Name' should be at least 5 characters long
> This is specially important in password fields, where the StringValidator is not usable because it displays the input in clear text on the web page:
> * 'x4eR4*z' is shorter than the minimum of 5 characters.
> should be
> * The field 'Password' should be at least 5 characters long

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2128) StringValidator error messages erroneously mention input instead of label

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-2128:
-------------------------------------

    Fix Version/s:     (was: 1.5-M3)
                   1.5-M4

> StringValidator error messages erroneously mention input instead of label
> -------------------------------------------------------------------------
>
>                 Key: WICKET-2128
>                 URL: https://issues.apache.org/jira/browse/WICKET-2128
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC2
>         Environment: any
>            Reporter: Rodrigo
>            Priority: Minor
>             Fix For: 1.5-M4
>
>
> Using a StringValidator.MaximumLengthValidator (or any flavor of the StringValidator class), the reported errors are currently under the form:
> StringValidator.minimum='${input}' is shorter than the minimum of ${minimum} characters.
> which creates odd messages where the content of the field is mentionned instead of the field label.
> Example:
> * 'Joe' is shorter than the minimum of 5 characters.
> should be
> * The field 'Name' should be at least 5 characters long
> This is specially important in password fields, where the StringValidator is not usable because it displays the input in clear text on the web page:
> * 'x4eR4*z' is shorter than the minimum of 5 characters.
> should be
> * The field 'Password' should be at least 5 characters long

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2128) StringValidator error messages erroneously mention input instead of label

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-2128:
----------------------------------

    Fix Version/s:     (was: 1.5-M1)
                   1.5-M2

> StringValidator error messages erroneously mention input instead of label
> -------------------------------------------------------------------------
>
>                 Key: WICKET-2128
>                 URL: https://issues.apache.org/jira/browse/WICKET-2128
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC2
>         Environment: any
>            Reporter: Rodrigo
>            Priority: Minor
>             Fix For: 1.5-M2
>
>
> Using a StringValidator.MaximumLengthValidator (or any flavor of the StringValidator class), the reported errors are currently under the form:
> StringValidator.minimum='${input}' is shorter than the minimum of ${minimum} characters.
> which creates odd messages where the content of the field is mentionned instead of the field label.
> Example:
> * 'Joe' is shorter than the minimum of 5 characters.
> should be
> * The field 'Name' should be at least 5 characters long
> This is specially important in password fields, where the StringValidator is not usable because it displays the input in clear text on the web page:
> * 'x4eR4*z' is shorter than the minimum of 5 characters.
> should be
> * The field 'Password' should be at least 5 characters long

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2128) StringValidator error messages erroneously mention input instead of label

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-2128:
----------------------------------

    Fix Version/s: 1.5-M1

this wasnt erroneous, some core committers were against changing this to use the newer label mechanism. we can revisit this in 1.5.

> StringValidator error messages erroneously mention input instead of label
> -------------------------------------------------------------------------
>
>                 Key: WICKET-2128
>                 URL: https://issues.apache.org/jira/browse/WICKET-2128
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC2
>         Environment: any
>            Reporter: Rodrigo
>            Priority: Minor
>             Fix For: 1.5-M1
>
>
> Using a StringValidator.MaximumLengthValidator (or any flavor of the StringValidator class), the reported errors are currently under the form:
> StringValidator.minimum='${input}' is shorter than the minimum of ${minimum} characters.
> which creates odd messages where the content of the field is mentionned instead of the field label.
> Example:
> * 'Joe' is shorter than the minimum of 5 characters.
> should be
> * The field 'Name' should be at least 5 characters long
> This is specially important in password fields, where the StringValidator is not usable because it displays the input in clear text on the web page:
> * 'x4eR4*z' is shorter than the minimum of 5 characters.
> should be
> * The field 'Password' should be at least 5 characters long

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.