You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/11/21 05:31:53 UTC

[GitHub] [druid] gianm commented on issue #13359: JSON serialization of LocalInputSource changes meaning of files

gianm commented on issue #13359:
URL: https://github.com/apache/druid/issues/13359#issuecomment-1321487632

   > The correct fix is probably to change the baseDir and files parameters to work with Strings rather than with File objects.
   
   I agree, that looks like the best fix to me too.
   
   > This would be a breaking change for anyone using the code API, but should be transparent to anyone using the JSON form.
   
   The individual InputSource implementations are not meant to be stable APIs, so it's OK to change this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org