[GitHub] [pulsar] poorbarcode commented on a diff in pull request #15051: [fix] [broker] Fix potential risk: Command-Subscribe add duplicated consumer

[GitBox <gi...@apache.org>]

poorbarcode commented on code in PR #15051:
URL: https://github.com/apache/pulsar/pull/15051#discussion_r844608754


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2737,6 +2729,7 @@ public void cancelPublishBufferLimiting() {
             if (e.getCause() instanceof BrokerServiceException) {
                 error = BrokerServiceException.getClientErrorCode(e.getCause());
             }
+            log.error("some thing error.", e);

Review Comment:
   That is a common method for "get error code from CompetableFuture", could not append more clear description



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org