[jira] [Comment Edited] (MESOS-4705) Slave failed to sample container with perf event

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257195#comment-15257195 ] 

Benjamin Mahler edited comment on MESOS-4705 at 4/25/16 10:49 PM:
------------------------------------------------------------------

[~fan.du] this is now committed, I'll backport this onto the stable branches for 0.28.x, 0.27.x, 0.26.x:

{noformat}
commit a5c81d4077400892cd3a5c306143f16903aac62c
Author: fan du <fa...@intel.com>
Date:   Mon Apr 25 13:50:50 2016 -0700

    Fixed the 'perf' parsing logic.

    Previously the 'perf' parsing logic used the kernel version to
    determine the token ordering. However, this approach breaks
    when distributions backport perf parsing changes onto older
    kernel versions. This updates the parsing logic to understand
    all existing formats.

    Co-authored with haosdent.

    Review: https://reviews.apache.org/r/44379/
{noformat}


was (Author: bmahler):
[~fan.du] this is now committed, I'll backport this onto the stable branches for 0.28.x, 0.27.x, 0.26.x.

> Slave failed to sample container with perf event
> ------------------------------------------------
>
>                 Key: MESOS-4705
>                 URL: https://issues.apache.org/jira/browse/MESOS-4705
>             Project: Mesos
>          Issue Type: Bug
>          Components: cgroups, isolation
>    Affects Versions: 0.27.1
>            Reporter: Fan Du
>            Assignee: Fan Du
>             Fix For: 0.29.0, 0.27.3, 0.28.2, 0.26.2
>
>
> When sampling container with perf event on Centos7 with kernel 
> 3.10.0-123.el7.x86_64, slave complained with below error spew:
> {code}
> E0218 16:32:00.591181  8376 perf_event.cpp:408] Failed to get perf sample: Failed to parse perf sample: Failed to parse perf sample line '25871993253,,cycles,mesos/5f23ffca-87ed-4ff6-84f2-6ec3d4098ab8,10059827422,100.00': Unexpected number of fields
> {code}
> it's caused by the current perf format [assumption | https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob;f=src/linux/perf.cpp;h=1c113a2b3f57877e132bbd65e01fb2f045132128;hb=HEAD#l430] with kernel version below 3.12 
> On 3.10.0-123.el7.x86_64 kernel, the format is with 6 tokens as below:
> value,unit,event,cgroup,running,ratio
> A local modification fixed this error on my test bed, please review this ticket.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)