[jira] [Commented] (HIVE-20797) Print Number of Locks Acquired

["Peter Vary (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-20797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705686#comment-16705686 ] 

Peter Vary commented on HIVE-20797:
-----------------------------------

[~belugabehr]: I had to look up {{MoreObjects}}, to find out what it does. In the current situation it is basically used for null check. Maybe the owner of the code wrote unit tests, maybe they really covered the situation above, but for a check this trivial in my opinion it is better/less error prone if the code is readable at first glance, so I would vote for the version where we do not use an extra class for this simple check.

> Print Number of Locks Acquired
> ------------------------------
>
>                 Key: HIVE-20797
>                 URL: https://issues.apache.org/jira/browse/HIVE-20797
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2, Locking
>    Affects Versions: 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>              Labels: newbie, noob
>         Attachments: HIVE-20797.1.patch
>
>
> The number of locks acquired by a query can greatly influence the performance and stability of the system, especially for ZK locks.  Please add INFO level logging with the number of locks each query obtains.
> Log here:
> https://github.com/apache/hive/blob/3963c729fabf90009cb67d277d40fe5913936358/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L1670-L1672
> {quote}
> A list of acquired locks will be stored in the org.apache.hadoop.hive.ql.Context object and can be retrieved via org.apache.hadoop.hive.ql.Context#getHiveLocks.
> {quote}
> https://github.com/apache/hive/blob/758ff449099065a84c46d63f9418201c8a6731b1/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManager.java#L115-L127



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)