[ https://issues.apache.org/jira/browse/FALCON-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946831#comment-13946831 ]
Venkatesh Seetharam commented on FALCON-376:
--------------------------------------------
Good catch. +1 to this jira.
> falcon start should fail if error in startup.properties
> -------------------------------------------------------
>
> Key: FALCON-376
> URL: https://issues.apache.org/jira/browse/FALCON-376
> Project: Falcon
> Issue Type: Bug
> Components: general
> Affects Versions: 0.4
> Reporter: Samarth Gupta
>
> if there is some error loading startup.properties falcon start should fail or atleast the exception shown on the console so that user is aware that some issue was there while start up.
> For example if :
> {code}
> *.current.colo=xyz
> {code}
> has a typo and written as
> {code}
> *current.colo=xyz
> {code}
> falcon server start ,with following error in logs :
> {code}
> 2014-03-25 07:11:21,271 DEBUG - [main:] ~ internal.queue.size=1000 (ApplicationProperties:146)
> 2014-03-25 07:11:21,271 DEBUG - [main:] ~ config.store.uri=file:///home/samarth/falcon/production/20140324/falcon-server-0.4.6-incubating-SNAPSHOT/store (ApplicationProperties:146)
> 2014-03-25 07:11:21,272 ERROR - [main:] ~ Failed startup of context org.mortbay.jetty.webapp.WebAppContext@d5d4de6{/,/home/samarth/falcon/inmobi/scm_49/falcon-server-0.4.6-incubatin
> g-SNAPSHOT/server/webapp/falcon.war} (log:87)
> java.lang.NullPointerException
> at java.util.regex.Matcher.getTextLength(Matcher.java:1140)
> at java.util.regex.Matcher.reset(Matcher.java:291)
> at java.util.regex.Matcher.<init>(Matcher.java:211)
> at java.util.regex.Pattern.matcher(Pattern.java:888)
> at org.apache.falcon.expression.ExpressionHelper.substitute(ExpressionHelper.java:189)
> at org.apache.falcon.expression.ExpressionHelper.substitute(ExpressionHelper.java:185)
> at org.apache.falcon.util.ApplicationProperties.doLoadProperties(ApplicationProperties.java:145)
> at org.apache.falcon.util.ApplicationProperties.loadProperties(ApplicationProperties.java:87)
> at org.apache.falcon.util.ApplicationProperties.loadProperties(ApplicationProperties.java:67)
> at org.apache.falcon.util.ApplicationProperties.init(ApplicationProperties.java:53)
> at org.apache.falcon.util.ApplicationProperties.<init>(ApplicationProperties.java:48)
> at org.apache.falcon.util.StartupProperties.<init>(StartupProperties.java:37)
> at org.apache.falcon.util.StartupProperties.get(StartupProperties.java:48)
> at org.apache.falcon.listener.ContextStartupListener.contextInitialized(ContextStartupListener.java:49)
> at org.mortbay.jetty.handler.ContextHandler.startContext(ContextHandler.java:549)
> at org.mortbay.jetty.servlet.Context.startContext(Context.java:136)
> at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1282)
> at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:518)
> at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:499)
> at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
> at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
> at org.mortbay.jetty.Server.doStart(Server.java:224)
> at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
> at org.apache.falcon.util.EmbeddedServer.start(EmbeddedServer.java:45)
> at org.apache.falcon.Main.main(Main.java:89)
> 2014-03-25 07:11:21,281 INFO - [main:] ~ Started SocketConnector@0.0.0.0:15000 (log:67)
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)