[GitHub] [mynewt-core] mkiiskila commented on a change in pull request #1885: kernel/os; fix core dumps & crash_restore_regs for M33.

[GitBox <gi...@apache.org>]

mkiiskila commented on a change in pull request #1885: kernel/os; fix core dumps & crash_restore_regs for M33.
URL: https://github.com/apache/mynewt-core/pull/1885#discussion_r295193233
 
 

 ##########
 File path: kernel/os/src/arch/cortex_m33/os_fault.c
 ##########
 @@ -96,27 +96,20 @@ trap_to_coredump(struct trap_frame *tf, struct coredump_regs *regs)
     regs->r12 = tf->ef->r12;
     /*
      * SP just before exception for the coredump.
-     * See ARMv7-M Architecture Ref Manual, sections B1.5.6 - B1.5.8
+     * See ARMv8-M Architecture Ref Manual, section E2.1.236
 
 Review comment:
   The pseudocode shows what gets pushed to stack in exception. So it is relevant :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services