You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/03/19 18:43:08 UTC

Review Request 32246: SQOOP-2235 Sqoop2: Move PrefixContext back to mapreduce execution engine

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32246/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2235
    https://issues.apache.org/jira/browse/SQOOP-2235


Repository: sqoop-sqoop2


Description
-------

I've moved the class back.


Diffs
-----

  common/src/main/java/org/apache/sqoop/common/PrefixContext.java c78616d 
  common/src/test/java/org/apache/sqoop/common/TestPrefixContext.java b4a4b00 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java 9fcd2a8 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java 3b81715 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java 4c5b0a0 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/PrefixContext.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java c6ba749 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java db31ca4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java d6fe6af 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java fc18586 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestPrefixContext.java PRE-CREATION 

Diff: https://reviews.apache.org/r/32246/diff/


Testing
-------

Tests seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request 32246: SQOOP-2235 Sqoop2: Move PrefixContext back to mapreduce execution engine

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32246/#review77478
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On March 19, 2015, 5:43 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32246/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 5:43 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2235
>     https://issues.apache.org/jira/browse/SQOOP-2235
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've moved the class back.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/common/PrefixContext.java c78616d 
>   common/src/test/java/org/apache/sqoop/common/TestPrefixContext.java b4a4b00 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java 9fcd2a8 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java 3b81715 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java 4c5b0a0 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/PrefixContext.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java c6ba749 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java db31ca4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java d6fe6af 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java fc18586 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestPrefixContext.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32246/diff/
> 
> 
> Testing
> -------
> 
> Tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>