You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/10 18:09:23 UTC

[GitHub] [airflow] dimberman commented on a change in pull request #11385: Add capability of customising PyPI sources

dimberman commented on a change in pull request #11385:
URL: https://github.com/apache/airflow/pull/11385#discussion_r502816373



##########
File path: docs/production-deployment.rst
##########
@@ -262,6 +262,14 @@ You can combine both - customizing & extending the image. You can build the imag
 ``customize`` method (either with docker command or with ``breeze`` and then you can ``extend``
 the resulting image using ``FROM`` any dependencies you want.
 
+Customizing PYPI installation
+.............................
+
+You can customize PYPI sources used during image build by modifying .pypirc file that should be
+placed in the root of Airflow Directory. The .pypirc will never be committed to the repository
+and it will not be present in the final production image. It is added and used only in the build

Review comment:
       ```suggestion
   and will not be present in the final production image. It is added and used only in the build
   ```

##########
File path: docs/production-deployment.rst
##########
@@ -262,6 +262,14 @@ You can combine both - customizing & extending the image. You can build the imag
 ``customize`` method (either with docker command or with ``breeze`` and then you can ``extend``
 the resulting image using ``FROM`` any dependencies you want.
 
+Customizing PYPI installation
+.............................
+
+You can customize PYPI sources used during image build by modifying .pypirc file that should be
+placed in the root of Airflow Directory. The .pypirc will never be committed to the repository

Review comment:
       ```suggestion
   placed in the root of Airflow Directory. This .pypirc will never be committed to the repository
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org