You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by zhuxt2015 <gi...@git.apache.org> on 2017/10/11 09:10:52 UTC
[GitHub] incubator-gearpump pull request #229: [GEARPUMP-350] Fix the not started app...
GitHub user zhuxt2015 opened a pull request:
https://github.com/apache/incubator-gearpump/pull/229
[GEARPUMP-350] Fix the not started app clock
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuxt2015/incubator-gearpump clock_not_start
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #229
----
commit 784d39ac5e9b1c912087829bd54bf347c12ce03f
Author: zhuxt2015 <59...@qq.com>
Date: 2017-10-11T07:58:43Z
Merge pull request #1 from apache/master
update
commit f0aec9ca07163d595b83945d8b94a64dfc728a18
Author: zhuxuetong@gridsum.com <zh...@gridsum.com>
Date: 2017-10-11T08:54:23Z
[GEARPUMP-350] Fix the not started app clock
----
---
[GitHub] incubator-gearpump pull request #229: [GEARPUMP-350] Fix the not started app...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/229#discussion_r143989762
--- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala ---
@@ -61,9 +61,9 @@ class Subscription(
private val processingWatermarkSince: Array[Short] = new Array[Short](parallelism)
private val outputWatermark: Array[MilliSeconds] = Array.fill(parallelism)(
- Watermark.MIN.toEpochMilli)
+ Watermark.MAX.toEpochMilli)
--- End diff --
This doesn't look right since the `watermark` method will return maximum value when the outgoing messages are not acked yet
---
[GitHub] incubator-gearpump pull request #229: [GEARPUMP-350] Fix the not started app...
Posted by zhuxt2015 <gi...@git.apache.org>.
Github user zhuxt2015 closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/229
---