You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2008/01/21 10:16:34 UTC
[jira] Created: (JCR-1331) Inproper deprecation of Locked class
Inproper deprecation of Locked class
------------------------------------
Key: JCR-1331
URL: https://issues.apache.org/jira/browse/JCR-1331
Project: Jackrabbit
Issue Type: Bug
Components: jackrabbit-jcr-commons
Affects Versions: 1.4
Reporter: Carsten Ziegeler
The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1331) Inproper deprecation of Locked class
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561314#action_12561314 ]
Jukka Zitting commented on JCR-1331:
------------------------------------
> Name, NamespaceResolver and NamePathResolver.
My patch replaces all those dependencies with code like the following:
session.getNamespacePrefix("http://www.jcp.org/jcr/mix/1.0") + ":lockable"
After that change the Lockable class only depends on the JCR API and should be just fine in jcr-commons. Most notably it meets the criteria defined in [1]:
"The jackrabbit-jcr-commons package should contain generic utility
classes that work *on top of* the JCR API. The classes should handle
names and paths in string format, and use the namespace methods on
javax.jcr.Session where name manipulation is needed."
> apart from that, there was no reason... and i don't have any strong feeling for
> the Locked class in particular nor about it's position in the code.
OK, thanks. Unless anyone has further objections I'll re-commit the patch in a few days time.
[1] http://www.mail-archive.com/dev@jackrabbit.apache.org/msg06698.html
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1331) Inproper deprecation of Locked class
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated JCR-1331:
------------------------
Component/s: jackrabbit-spi-commons
adjusting affected projects.
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons, jackrabbit-spi-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (JCR-1331) Inproper deprecation of Locked class
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela reopened JCR-1331:
-------------------------
sorry. i don't agree on this change.
and: jukka, i would expect that you wait at least for one day before you
make such modifications.
my suggestion to move the Locked class was by intention, i expect that at least
give me the change to tell you so.
can you please revert your modification made with r613841 unless we reached
consensus on this issue? thanks
angela
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1331) Improper deprecation of Locked class
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated JCR-1331:
-----------------------------------
Fix Version/s: 1.5
> Improper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: commons 1.4.2, 1.5
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1331) Inproper deprecation of Locked class
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-1331.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.4.1
Fixed in revision 613834. Thanks!
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1331) Inproper deprecation of Locked class
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560982#action_12560982 ]
Carsten Ziegeler commented on JCR-1331:
---------------------------------------
What about the version in the spi-commons? Shouldn't it be deprecated?
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JCR-1331) Improper deprecation of Locked class
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed JCR-1331.
----------------------------------
Closing issue, has been release in jackrabbit-jcr-commons 1.4.2
> Improper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: commons 1.4.2, 1.5
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1331) Inproper deprecation of Locked class
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1331:
-------------------------------
Attachment: JCR-1331.patch
> sorry. i don't agree on this change.
Ah, I'm sorry for jumping the fox here. I've reverted my changes in revision 614158.
For the record, the reverted changes are included in the attached patch.
> and: jukka, i would expect that you wait at least for one day before you
> make such modifications.
My apologies. I thought this was a clear-cut issue so I didn't wait for review. Obviously I was wrong.
Was there some other reason than the Name dependencies for moving the Locked class?
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JCR-1331) Inproper deprecation of Locked class
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed JCR-1331.
---------------------------------
Thanks!
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1331) Inproper deprecation of Locked class
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting reassigned JCR-1331:
----------------------------------
Assignee: Jukka Zitting
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1331) Improper deprecation of Locked class
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-1331.
--------------------------------
Resolution: Fixed
Fixed in jackrabbit-jcr-commons in revision 638099. Merged to the 1.4 branch in revision 638100.
> Improper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: commons 1.4.1
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1331) Inproper deprecation of Locked class
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561332#action_12561332 ]
angela commented on JCR-1331:
-----------------------------
> Unless anyone has further objections I'll re-commit the patch in a few days time.
fine with me.
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1331) Improper deprecation of Locked class
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Guggisberg updated JCR-1331:
-----------------------------------
Summary: Improper deprecation of Locked class (was: Inproper deprecation of Locked class)
> Improper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons, jackrabbit-spi-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1331) Inproper deprecation of Locked class
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561298#action_12561298 ]
angela commented on JCR-1331:
-----------------------------
> was there some other reason than the Name dependencies for moving the Locked class?
Name, NamespaceResolver and NamePathResolver.
apart from that, there was no reason... and i don't have any strong feeling for the Locked class
in particular nor about it's position in the code.
but i expect that we have a minimal response time to give everybody the time to look at a patch. apart from that i expect that patches and suggestions are really looked at, before they are commited. this applies both for this one and the one in JCR-1169 which was open for almost a month (and already suggested in the devlist before). that's all.
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1331) Improper deprecation of Locked class
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1331:
-------------------------------
Component/s: (was: jackrabbit-spi-commons)
Priority: Minor (was: Major)
Fix Version/s: (was: 1.4.1)
commons 1.4.1
Re-purposing this as a purely jcr-commons issue to avoid cross-component complexity. We should add a separate issue
to deprecate the class in spi-commons 1.5.
> Improper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: commons 1.4.1
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1331) Inproper deprecation of Locked class
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560987#action_12560987 ]
Jukka Zitting commented on JCR-1331:
------------------------------------
Probably, but we shouldn't deprecate things in a patch release, so it'll have to wait until 1.5.
Anyway, I've added the @deprecate marker to spi-commons in revision 613841. I'll figure out how to best handle these changes in terms of release tracking.
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.