You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by Craig Russell <ap...@gmail.com> on 2021/02/08 22:21:16 UTC
Bug in secretary workbench
Whenever I file a document, I get the
error message: Warning: Invalid From address
Continue anyway?
But there is nothing wrong with the address, and everything completes normally, and at the end, another warning with a red (return to mail index)
The headers look fine and the mail is processed normally. [1]
Any ideas?
Thanks,
Craig
[1] Date: Mon, 08 Feb 2021 22:12:26 +0000
From: Craig L Russell <cl...@apache.org>
To: root@apache.org
Cc: Daniel Gomm <da...@outlook.de>,
private@incubator.apache.org,
private@streampipes.apache.org
Message-ID: <60...@whimsy-vm6.mail>
Subject: [FORM] Account Request - daniel.gomm@outlook.de: Daniel Gomm
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Craig L Russell
clr@apache.org
Re: Bug in secretary workbench
Posted by sebb <se...@gmail.com>.
This is why the *exact* error message is needed to debug the code.
On Wed, 10 Feb 2021 at 01:35, Matt Sicker <bo...@gmail.com> wrote:
>
> That looks like the same regex code, so I'm not sure what's going on.
>
> On Tue, 9 Feb 2021 at 18:41, Craig Russell <ap...@gmail.com> wrote:
> >
> > I think this is the change that made the error occur.
> >
> > https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5 <https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5>
> >
> > @from.untaint if @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
> >
> > was changed to
> >
> >
> > _warn "Invalid From address #{@from}" unless @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
> >
> > I looked at some of the other actions, e.g. ccla.json.rb grant.json.rb and they do not have a similar email check.
> >
> > So, why is this necessary? And can the check pass my email address? "Craig L Russell <clr@apache.org <ma...@apache.org>>"
> >
> > Craig
> >
> >
> > > On Feb 8, 2021, at 3:51 PM, sebb <se...@gmail.com> wrote:
> > >
> > > A quick search in GitHub gives the following:
> > >
> > > https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22
> > >
> > > https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/secretary/workbench/views/actions/icla.json.rb#L13
> > >
> > > At a quick glance RE looks OK. And AFAIK, no-one else has reported the issue.
> > >
> > > To proceed further you would need the exact error message.
> > >
> > > On Mon, 8 Feb 2021 at 22:21, Craig Russell <ap...@gmail.com> wrote:
> > >>
> > >> Whenever I file a document, I get the
> > >>
> > >> error message: Warning: Invalid From address
> > >> Continue anyway?
> > >>
> > >> But there is nothing wrong with the address, and everything completes normally, and at the end, another warning with a red (return to mail index)
> > >>
> > >> The headers look fine and the mail is processed normally. [1]
> > >>
> > >> Any ideas?
> > >>
> > >> Thanks,
> > >> Craig
> > >>
> > >> [1] Date: Mon, 08 Feb 2021 22:12:26 +0000
> > >> From: Craig L Russell <cl...@apache.org>
> > >> To: root@apache.org
> > >> Cc: Daniel Gomm <da...@outlook.de>,
> > >> private@incubator.apache.org,
> > >> private@streampipes.apache.org
> > >> Message-ID: <60...@whimsy-vm6.mail>
> > >> Subject: [FORM] Account Request - daniel.gomm@outlook.de: Daniel Gomm
> > >> Mime-Version: 1.0
> > >> Content-Type: text/plain;
> > >> charset=UTF-8
> > >> Content-Transfer-Encoding: 7bit
> > >>
> > >>
> > >>
> > >> Craig L Russell
> > >> clr@apache.org
> > >>
> >
> > Craig L Russell
> > clr@apache.org
> >
Re: Bug in secretary workbench
Posted by Craig Russell <ap...@gmail.com>.
Hi Sebb,
Your patch seems to have fixed the problem.
The only remaining question for me is whether the validity of the @from variable should be in any other document processing tasks (ccla, grant, emeritus).
Thanks,
Craig
> On Feb 11, 2021, at 4:44 AM, sebb <se...@gmail.com> wrote:
>
> On Thu, 11 Feb 2021 at 02:10, Craig Russell <apache.clr@gmail.com <ma...@gmail.com>> wrote:
>>
>> I have to say that mail clients do mess up email addresses, so I'll double check this one.
>>
>> The error message would indicate that the @from variable is actually empty:
>>
>> Warning: Invalid From address ''
>>
>>
>> The actual @from email address in the message-to-be-sent is:
>>
>> Craig L Russell <cl...@apache.org>
>>
>> I dunno where the non-email-address apache.clr@apache.org came from. Not from anything I wrote I hope.
>>
>> So we need to look at the @from variable.
>
> It appears to be empty at the point where it is checked, whereas it is
> set where it is used to create the message around line 133 in
> icla.json.rb
> It is not updated anywhere in that file, so I assume var must be part
> of the context established by the 'task' block.
>
>> And also figure out why this check is necessary, since there is no similar check in other document filing code (ccla, grant, emeritus).
>
> The check was added a long time ago in the form of a taint check.
> This was converted into a warning when Ruby taint was deprecated.
>
> Whether the check is needed depends on whether the variable value can
> be misused to cause a problem.
> I have moved the check to the task block.
>
> If it continues to cause an issue, we can investigate whether it can
> safely be dropped.
>
>> Craig
>>
>>> On Feb 10, 2021, at 5:14 PM, sebb <se...@gmail.com> wrote:
>>>
>>> The error message suggests that the @from variable is empty, so no
>>> wonder the RE fails.
>>>
>>> On Wed, 10 Feb 2021 at 18:08, Roy T. Fielding <fi...@gbiv.com> wrote:
>>>>
>>>> Wow, Apple Mail really messed that up by adding mailto links everywhere. What I meant was
>>>>
>>>> you should also note that \w excludes hyphen and ".", so apache.clr@apache.org
>>>> will not match regardless. You need [\w\+\=\.\-]+@apache.org (or something), or
>>>> just check the end with /\@apache\.org>?$/
>>>
>>> I don't think apache.clr@apache.org is currently possible as an ASF
>>> email, but point taken, the RE could be a bit less strict.
>>>
>>> However, given that @from appears to be empty, I wonder if it is necessary.
>>> This needs to be checked.
>>>
>>>> ....Roy
>>>>
>>
>> Craig L Russell
>> clr@apache.org
Craig L Russell
clr@apache.org
Re: Bug in secretary workbench
Posted by sebb <se...@gmail.com>.
On Thu, 11 Feb 2021 at 02:10, Craig Russell <ap...@gmail.com> wrote:
>
> I have to say that mail clients do mess up email addresses, so I'll double check this one.
>
> The error message would indicate that the @from variable is actually empty:
>
> Warning: Invalid From address ''
>
>
> The actual @from email address in the message-to-be-sent is:
>
> Craig L Russell <cl...@apache.org>
>
> I dunno where the non-email-address apache.clr@apache.org came from. Not from anything I wrote I hope.
>
> So we need to look at the @from variable.
It appears to be empty at the point where it is checked, whereas it is
set where it is used to create the message around line 133 in
icla.json.rb
It is not updated anywhere in that file, so I assume var must be part
of the context established by the 'task' block.
> And also figure out why this check is necessary, since there is no similar check in other document filing code (ccla, grant, emeritus).
The check was added a long time ago in the form of a taint check.
This was converted into a warning when Ruby taint was deprecated.
Whether the check is needed depends on whether the variable value can
be misused to cause a problem.
I have moved the check to the task block.
If it continues to cause an issue, we can investigate whether it can
safely be dropped.
> Craig
>
> > On Feb 10, 2021, at 5:14 PM, sebb <se...@gmail.com> wrote:
> >
> > The error message suggests that the @from variable is empty, so no
> > wonder the RE fails.
> >
> > On Wed, 10 Feb 2021 at 18:08, Roy T. Fielding <fi...@gbiv.com> wrote:
> >>
> >> Wow, Apple Mail really messed that up by adding mailto links everywhere. What I meant was
> >>
> >> you should also note that \w excludes hyphen and ".", so apache.clr@apache.org
> >> will not match regardless. You need [\w\+\=\.\-]+@apache.org (or something), or
> >> just check the end with /\@apache\.org>?$/
> >
> > I don't think apache.clr@apache.org is currently possible as an ASF
> > email, but point taken, the RE could be a bit less strict.
> >
> > However, given that @from appears to be empty, I wonder if it is necessary.
> > This needs to be checked.
> >
> >> ....Roy
> >>
>
> Craig L Russell
> clr@apache.org
>
Re: Bug in secretary workbench
Posted by Craig Russell <ap...@gmail.com>.
I have to say that mail clients do mess up email addresses, so I'll double check this one.
The error message would indicate that the @from variable is actually empty:
Warning: Invalid From address ''
The actual @from email address in the message-to-be-sent is:
Craig L Russell <cl...@apache.org>
I dunno where the non-email-address apache.clr@apache.org came from. Not from anything I wrote I hope.
So we need to look at the @from variable.
And also figure out why this check is necessary, since there is no similar check in other document filing code (ccla, grant, emeritus).
Craig
> On Feb 10, 2021, at 5:14 PM, sebb <se...@gmail.com> wrote:
>
> The error message suggests that the @from variable is empty, so no
> wonder the RE fails.
>
> On Wed, 10 Feb 2021 at 18:08, Roy T. Fielding <fi...@gbiv.com> wrote:
>>
>> Wow, Apple Mail really messed that up by adding mailto links everywhere. What I meant was
>>
>> you should also note that \w excludes hyphen and ".", so apache.clr@apache.org
>> will not match regardless. You need [\w\+\=\.\-]+@apache.org (or something), or
>> just check the end with /\@apache\.org>?$/
>
> I don't think apache.clr@apache.org is currently possible as an ASF
> email, but point taken, the RE could be a bit less strict.
>
> However, given that @from appears to be empty, I wonder if it is necessary.
> This needs to be checked.
>
>> ....Roy
>>
Craig L Russell
clr@apache.org
Re: Bug in secretary workbench
Posted by sebb <se...@gmail.com>.
The error message suggests that the @from variable is empty, so no
wonder the RE fails.
On Wed, 10 Feb 2021 at 18:08, Roy T. Fielding <fi...@gbiv.com> wrote:
>
> Wow, Apple Mail really messed that up by adding mailto links everywhere. What I meant was
>
> you should also note that \w excludes hyphen and ".", so apache.clr@apache.org
> will not match regardless. You need [\w\+\=\.\-]+@apache.org (or something), or
> just check the end with /\@apache\.org>?$/
I don't think apache.clr@apache.org is currently possible as an ASF
email, but point taken, the RE could be a bit less strict.
However, given that @from appears to be empty, I wonder if it is necessary.
This needs to be checked.
> ....Roy
>
Re: Bug in secretary workbench
Posted by "Roy T. Fielding" <fi...@gbiv.com>.
Wow, Apple Mail really messed that up by adding mailto links everywhere. What I meant was
you should also note that \w excludes hyphen and ".", so apache.clr@apache.org
will not match regardless. You need [\w\+\=\.\-]+@apache.org (or something), or
just check the end with /\@apache\.org>?$/
....Roy
Re: Bug in secretary workbench
Posted by "Roy T. Fielding" <fi...@gbiv.com>.
Just a guess, but the =~ operator in Ruby returns either the index inside the string
where the match is found or nil, depending on the context. You might want to try
_warn "Invalid From address #{@from}" if @from !~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
but you should also note that \w excludes hyphen and ".", so apache.clr@apache.org <ma...@apache.org>
will not match regardless. You need [\w\+\=\.\-]+@apache.org <http://apache.org/> (or something), or just
check the end with /\@apache.org>?$/
....Roy
> On Feb 9, 2021, at 5:34 PM, Matt Sicker <bo...@gmail.com> wrote:
>
> That looks like the same regex code, so I'm not sure what's going on.
>
> On Tue, 9 Feb 2021 at 18:41, Craig Russell <ap...@gmail.com> wrote:
>>
>> I think this is the change that made the error occur.
>>
>> https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5 <https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5>
>>
>> @from.untaint if @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
>>
>> was changed to
>>
>>
>> _warn "Invalid From address #{@from}" unless @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
>>
>> I looked at some of the other actions, e.g. ccla.json.rb grant.json.rb and they do not have a similar email check.
>>
>> So, why is this necessary? And can the check pass my email address? "Craig L Russell <clr@apache.org <ma...@apache.org>>"
>>
>> Craig
>>
>>
>>> On Feb 8, 2021, at 3:51 PM, sebb <se...@gmail.com> wrote:
>>>
>>> A quick search in GitHub gives the following:
>>>
>>> https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22
>>>
>>> https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/secretary/workbench/views/actions/icla.json.rb#L13
>>>
>>> At a quick glance RE looks OK. And AFAIK, no-one else has reported the issue.
>>>
>>> To proceed further you would need the exact error message.
>>>
>>> On Mon, 8 Feb 2021 at 22:21, Craig Russell <ap...@gmail.com> wrote:
>>>>
>>>> Whenever I file a document, I get the
>>>>
>>>> error message: Warning: Invalid From address
>>>> Continue anyway?
>>>>
>>>> But there is nothing wrong with the address, and everything completes normally, and at the end, another warning with a red (return to mail index)
>>>>
>>>> The headers look fine and the mail is processed normally. [1]
>>>>
>>>> Any ideas?
>>>>
>>>> Thanks,
>>>> Craig
>>>>
>>>> [1] Date: Mon, 08 Feb 2021 22:12:26 +0000
>>>> From: Craig L Russell <cl...@apache.org>
>>>> To: root@apache.org
>>>> Cc: Daniel Gomm <da...@outlook.de>,
>>>> private@incubator.apache.org,
>>>> private@streampipes.apache.org
>>>> Message-ID: <60...@whimsy-vm6.mail>
>>>> Subject: [FORM] Account Request - daniel.gomm@outlook.de: Daniel Gomm
>>>> Mime-Version: 1.0
>>>> Content-Type: text/plain;
>>>> charset=UTF-8
>>>> Content-Transfer-Encoding: 7bit
>>>>
>>>>
>>>>
>>>> Craig L Russell
>>>> clr@apache.org
>>>>
>>
>> Craig L Russell
>> clr@apache.org
>>
Re: Bug in secretary workbench
Posted by Matt Sicker <bo...@gmail.com>.
That looks like the same regex code, so I'm not sure what's going on.
On Tue, 9 Feb 2021 at 18:41, Craig Russell <ap...@gmail.com> wrote:
>
> I think this is the change that made the error occur.
>
> https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5 <https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5>
>
> @from.untaint if @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
>
> was changed to
>
>
> _warn "Invalid From address #{@from}" unless @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
>
> I looked at some of the other actions, e.g. ccla.json.rb grant.json.rb and they do not have a similar email check.
>
> So, why is this necessary? And can the check pass my email address? "Craig L Russell <clr@apache.org <ma...@apache.org>>"
>
> Craig
>
>
> > On Feb 8, 2021, at 3:51 PM, sebb <se...@gmail.com> wrote:
> >
> > A quick search in GitHub gives the following:
> >
> > https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22
> >
> > https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/secretary/workbench/views/actions/icla.json.rb#L13
> >
> > At a quick glance RE looks OK. And AFAIK, no-one else has reported the issue.
> >
> > To proceed further you would need the exact error message.
> >
> > On Mon, 8 Feb 2021 at 22:21, Craig Russell <ap...@gmail.com> wrote:
> >>
> >> Whenever I file a document, I get the
> >>
> >> error message: Warning: Invalid From address
> >> Continue anyway?
> >>
> >> But there is nothing wrong with the address, and everything completes normally, and at the end, another warning with a red (return to mail index)
> >>
> >> The headers look fine and the mail is processed normally. [1]
> >>
> >> Any ideas?
> >>
> >> Thanks,
> >> Craig
> >>
> >> [1] Date: Mon, 08 Feb 2021 22:12:26 +0000
> >> From: Craig L Russell <cl...@apache.org>
> >> To: root@apache.org
> >> Cc: Daniel Gomm <da...@outlook.de>,
> >> private@incubator.apache.org,
> >> private@streampipes.apache.org
> >> Message-ID: <60...@whimsy-vm6.mail>
> >> Subject: [FORM] Account Request - daniel.gomm@outlook.de: Daniel Gomm
> >> Mime-Version: 1.0
> >> Content-Type: text/plain;
> >> charset=UTF-8
> >> Content-Transfer-Encoding: 7bit
> >>
> >>
> >>
> >> Craig L Russell
> >> clr@apache.org
> >>
>
> Craig L Russell
> clr@apache.org
>
Re: Bug in secretary workbench
Posted by Matt Sicker <bo...@gmail.com>.
Current error message says:
Warning: Invalid From address ''
On Wed, 10 Feb 2021 at 05:53, sebb <se...@gmail.com> wrote:
>
> On Wed, 10 Feb 2021 at 00:41, Craig Russell <ap...@gmail.com> wrote:
> >
> > I think this is the change that made the error occur.
> >
> > https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5 <https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5>
> >
> > @from.untaint if @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
> >
> > was changed to
> >
> >
> > _warn "Invalid From address #{@from}" unless @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
> >
> > I looked at some of the other actions, e.g. ccla.json.rb grant.json.rb and they do not have a similar email check.
> >
> > So, why is this necessary? And can the check pass my email address? "Craig L Russell <clr@apache.org <ma...@apache.org>>"
>
> That is not a valid email address.
>
> It should be
>
> "Craig L Russell <cl...@apache.org>"
>
> > Craig
> >
> >
> > > On Feb 8, 2021, at 3:51 PM, sebb <se...@gmail.com> wrote:
> > >
> > > A quick search in GitHub gives the following:
> > >
> > > https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22
> > >
> > > https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/secretary/workbench/views/actions/icla.json.rb#L13
> > >
> > > At a quick glance RE looks OK. And AFAIK, no-one else has reported the issue.
> > >
> > > To proceed further you would need the exact error message.
> > >
> > > On Mon, 8 Feb 2021 at 22:21, Craig Russell <ap...@gmail.com> wrote:
> > >>
> > >> Whenever I file a document, I get the
> > >>
> > >> error message: Warning: Invalid From address
> > >> Continue anyway?
> > >>
> > >> But there is nothing wrong with the address, and everything completes normally, and at the end, another warning with a red (return to mail index)
> > >>
> > >> The headers look fine and the mail is processed normally. [1]
> > >>
> > >> Any ideas?
> > >>
> > >> Thanks,
> > >> Craig
> > >>
> > >> [1] Date: Mon, 08 Feb 2021 22:12:26 +0000
> > >> From: Craig L Russell <cl...@apache.org>
> > >> To: root@apache.org
> > >> Cc: Daniel Gomm <da...@outlook.de>,
> > >> private@incubator.apache.org,
> > >> private@streampipes.apache.org
> > >> Message-ID: <60...@whimsy-vm6.mail>
> > >> Subject: [FORM] Account Request - daniel.gomm@outlook.de: Daniel Gomm
> > >> Mime-Version: 1.0
> > >> Content-Type: text/plain;
> > >> charset=UTF-8
> > >> Content-Transfer-Encoding: 7bit
> > >>
> > >>
> > >>
> > >> Craig L Russell
> > >> clr@apache.org
> > >>
> >
> > Craig L Russell
> > clr@apache.org
> >
Re: Bug in secretary workbench
Posted by sebb <se...@gmail.com>.
On Wed, 10 Feb 2021 at 00:41, Craig Russell <ap...@gmail.com> wrote:
>
> I think this is the change that made the error occur.
>
> https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5 <https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5>
>
> @from.untaint if @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
>
> was changed to
>
>
> _warn "Invalid From address #{@from}" unless @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
>
> I looked at some of the other actions, e.g. ccla.json.rb grant.json.rb and they do not have a similar email check.
>
> So, why is this necessary? And can the check pass my email address? "Craig L Russell <clr@apache.org <ma...@apache.org>>"
That is not a valid email address.
It should be
"Craig L Russell <cl...@apache.org>"
> Craig
>
>
> > On Feb 8, 2021, at 3:51 PM, sebb <se...@gmail.com> wrote:
> >
> > A quick search in GitHub gives the following:
> >
> > https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22
> >
> > https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/secretary/workbench/views/actions/icla.json.rb#L13
> >
> > At a quick glance RE looks OK. And AFAIK, no-one else has reported the issue.
> >
> > To proceed further you would need the exact error message.
> >
> > On Mon, 8 Feb 2021 at 22:21, Craig Russell <ap...@gmail.com> wrote:
> >>
> >> Whenever I file a document, I get the
> >>
> >> error message: Warning: Invalid From address
> >> Continue anyway?
> >>
> >> But there is nothing wrong with the address, and everything completes normally, and at the end, another warning with a red (return to mail index)
> >>
> >> The headers look fine and the mail is processed normally. [1]
> >>
> >> Any ideas?
> >>
> >> Thanks,
> >> Craig
> >>
> >> [1] Date: Mon, 08 Feb 2021 22:12:26 +0000
> >> From: Craig L Russell <cl...@apache.org>
> >> To: root@apache.org
> >> Cc: Daniel Gomm <da...@outlook.de>,
> >> private@incubator.apache.org,
> >> private@streampipes.apache.org
> >> Message-ID: <60...@whimsy-vm6.mail>
> >> Subject: [FORM] Account Request - daniel.gomm@outlook.de: Daniel Gomm
> >> Mime-Version: 1.0
> >> Content-Type: text/plain;
> >> charset=UTF-8
> >> Content-Transfer-Encoding: 7bit
> >>
> >>
> >>
> >> Craig L Russell
> >> clr@apache.org
> >>
>
> Craig L Russell
> clr@apache.org
>
Re: Bug in secretary workbench
Posted by Craig Russell <ap...@gmail.com>.
I think this is the change that made the error occur.
https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5 <https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5>
@from.untaint if @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
was changed to
_warn "Invalid From address #{@from}" unless @from =~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/
I looked at some of the other actions, e.g. ccla.json.rb grant.json.rb and they do not have a similar email check.
So, why is this necessary? And can the check pass my email address? "Craig L Russell <clr@apache.org <ma...@apache.org>>"
Craig
> On Feb 8, 2021, at 3:51 PM, sebb <se...@gmail.com> wrote:
>
> A quick search in GitHub gives the following:
>
> https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22
>
> https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/secretary/workbench/views/actions/icla.json.rb#L13
>
> At a quick glance RE looks OK. And AFAIK, no-one else has reported the issue.
>
> To proceed further you would need the exact error message.
>
> On Mon, 8 Feb 2021 at 22:21, Craig Russell <ap...@gmail.com> wrote:
>>
>> Whenever I file a document, I get the
>>
>> error message: Warning: Invalid From address
>> Continue anyway?
>>
>> But there is nothing wrong with the address, and everything completes normally, and at the end, another warning with a red (return to mail index)
>>
>> The headers look fine and the mail is processed normally. [1]
>>
>> Any ideas?
>>
>> Thanks,
>> Craig
>>
>> [1] Date: Mon, 08 Feb 2021 22:12:26 +0000
>> From: Craig L Russell <cl...@apache.org>
>> To: root@apache.org
>> Cc: Daniel Gomm <da...@outlook.de>,
>> private@incubator.apache.org,
>> private@streampipes.apache.org
>> Message-ID: <60...@whimsy-vm6.mail>
>> Subject: [FORM] Account Request - daniel.gomm@outlook.de: Daniel Gomm
>> Mime-Version: 1.0
>> Content-Type: text/plain;
>> charset=UTF-8
>> Content-Transfer-Encoding: 7bit
>>
>>
>>
>> Craig L Russell
>> clr@apache.org
>>
Craig L Russell
clr@apache.org
Re: Bug in secretary workbench
Posted by Matt Sicker <bo...@gmail.com>.
I’ve been getting the same error message.
On Mon, Feb 8, 2021 at 17:51 sebb <se...@gmail.com> wrote:
> A quick search in GitHub gives the following:
>
> https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22
>
>
> https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/secretary/workbench/views/actions/icla.json.rb#L13
>
> At a quick glance RE looks OK. And AFAIK, no-one else has reported the
> issue.
>
> To proceed further you would need the exact error message.
>
> On Mon, 8 Feb 2021 at 22:21, Craig Russell <ap...@gmail.com> wrote:
> >
> > Whenever I file a document, I get the
> >
> > error message: Warning: Invalid From address
> > Continue anyway?
> >
> > But there is nothing wrong with the address, and everything completes
> normally, and at the end, another warning with a red (return to mail index)
> >
> > The headers look fine and the mail is processed normally. [1]
> >
> > Any ideas?
> >
> > Thanks,
> > Craig
> >
> > [1] Date: Mon, 08 Feb 2021 22:12:26 +0000
> > From: Craig L Russell <cl...@apache.org>
> > To: root@apache.org
> > Cc: Daniel Gomm <da...@outlook.de>,
> > private@incubator.apache.org,
> > private@streampipes.apache.org
> > Message-ID: <60...@whimsy-vm6.mail>
> > Subject: [FORM] Account Request - daniel.gomm@outlook.de: Daniel Gomm
> > Mime-Version: 1.0
> > Content-Type: text/plain;
> > charset=UTF-8
> > Content-Transfer-Encoding: 7bit
> >
> >
> >
> > Craig L Russell
> > clr@apache.org
> >
>
Re: Bug in secretary workbench
Posted by sebb <se...@gmail.com>.
A quick search in GitHub gives the following:
https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22
https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/secretary/workbench/views/actions/icla.json.rb#L13
At a quick glance RE looks OK. And AFAIK, no-one else has reported the issue.
To proceed further you would need the exact error message.
On Mon, 8 Feb 2021 at 22:21, Craig Russell <ap...@gmail.com> wrote:
>
> Whenever I file a document, I get the
>
> error message: Warning: Invalid From address
> Continue anyway?
>
> But there is nothing wrong with the address, and everything completes normally, and at the end, another warning with a red (return to mail index)
>
> The headers look fine and the mail is processed normally. [1]
>
> Any ideas?
>
> Thanks,
> Craig
>
> [1] Date: Mon, 08 Feb 2021 22:12:26 +0000
> From: Craig L Russell <cl...@apache.org>
> To: root@apache.org
> Cc: Daniel Gomm <da...@outlook.de>,
> private@incubator.apache.org,
> private@streampipes.apache.org
> Message-ID: <60...@whimsy-vm6.mail>
> Subject: [FORM] Account Request - daniel.gomm@outlook.de: Daniel Gomm
> Mime-Version: 1.0
> Content-Type: text/plain;
> charset=UTF-8
> Content-Transfer-Encoding: 7bit
>
>
>
> Craig L Russell
> clr@apache.org
>