You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/30 20:55:39 UTC

[GitHub] [arrow-rs] Dandandan commented on pull request #383: Add set_bit to BooleanBufferBuilder to allow mutating bit in index

Dandandan commented on pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#issuecomment-851059933


   I added some details on the ASF Slack. I think the change is fine, but only the tests should be fixed.
   
   Maybe it makes sense to expose `is_set` as well? This also could make the tests a bit more intuitive.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org