[GitHub] [iotdb] ycycse commented on a diff in pull request #9967: [IOTDB-5930] Support OrderBy in Last Query

["ycycse (via GitHub)" <gi...@apache.org>]

ycycse commented on code in PR #9967:
URL: https://github.com/apache/iotdb/pull/9967#discussion_r1210079116


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/LogicalPlanBuilder.java:
##########
@@ -1215,6 +1213,16 @@ private LogicalPlanBuilder planSingleShowQueries(TDataNodeLocation dataNodeLocat
     return this;
   }
 
+  public LogicalPlanBuilder planOrderBy(List<SortItem> sortItemList) {
+    OrderByParameter orderByParameter = new OrderByParameter(sortItemList);
+    if (orderByParameter.isEmpty()) {
+      return this;
+    }
+
+    this.root = new SortNode(context.getQueryId().genPlanNodeId(), root, orderByParameter);
+    return this;

Review Comment:
   done



##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/Analysis.java:
##########
@@ -195,6 +196,8 @@ public class Analysis {
 
   private OrderByParameter mergeOrderParameter;
 
+  private Ordering timeseriesOrderingForLastQuery = null;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org