You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/09/20 13:38:48 UTC
[PR] Fix the test compilation after #157 and #167 crossed [maven-jarsigner-plugin]
slachiewicz opened a new pull request, #170:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/170
Master does not compile its tests: #167 dropped Hamcrest and made `RequestMatchers` return Mockito `ArgumentMatcher`s, while #157, written before that and merged after it, added `testIncludesFilterWithArchiveDirectory` with `MockitoHamcrest.argThat(...)`. The test now uses Mockito's own `argThat`/`never`, which is what the rest of the class already does. Every PR build is red until this lands (#169 shows it).
Verified: `mvn verify` → 51 tests, 0 failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the test compilation after #157 and #167 crossed [maven-jarsigner-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #170:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/170#issuecomment-5750198078
Exactly the sort of bug submit queues are meant to prevent. Haven't thought about those for a while, but this isn't the first time this has happened to me. I wonder if GitHub supports them? Looks like it does though it calls them "merge queues"
https://github.blog/news-insights/product-news/github-merge-queue-is-generally-available/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the test compilation after #157 and #167 crossed [maven-jarsigner-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #170:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org