You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/18 16:52:05 UTC
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10095
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
[Java] Mark the Yetus annotations dependency optional
Given the Yetus dependency is mainly used for documentation
generation and is not used at runtime, we can mark the
annotation as optional for users consuming Kudu.
This is similar to the jsr305 dependency which we mark
as optional.
Additionally we don’t need to include Yetus in our shaded
jars.
Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
14 files changed, 55 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/10095/1
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10095
to look at the new patch set (#3).
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
[Java] Mark the Yetus annotations dependency optional
Given the Yetus dependency is mainly used for documentation
generation and is not used at runtime, we can mark the
annotation as optional for users consuming Kudu.
This is similar to the jsr305 dependency which we mark
as optional.
Additionally we don’t need to include Yetus in our shaded
jars.
Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
14 files changed, 55 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/10095/3
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 )
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10095/2/java/kudu-spark-tools/build.gradle
File java/kudu-spark-tools/build.gradle:
http://gerrit.cloudera.org:8080/#/c/10095/2/java/kudu-spark-tools/build.gradle@a26
PS2, Line 26:
Nit: an empty line here is actually nice, it helps emphasize the comment below it.
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 18 Apr 2018 19:24:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 )
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10095/2/java/kudu-spark-tools/build.gradle
File java/kudu-spark-tools/build.gradle:
http://gerrit.cloudera.org:8080/#/c/10095/2/java/kudu-spark-tools/build.gradle@a26
PS2, Line 26:
> Nit: an empty line here is actually nice, it helps emphasize the comment be
Done
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 19 Apr 2018 13:25:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10095
to look at the new patch set (#2).
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
[Java] Mark the Yetus annotations dependency optional
Given the Yetus dependency is mainly used for documentation
generation and is not used at runtime, we can mark the
annotation as optional for users consuming Kudu.
This is similar to the jsr305 dependency which we mark
as optional.
Additionally we don’t need to include Yetus in our shaded
jars.
Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
14 files changed, 55 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/10095/2
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10095 )
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
[Java] Mark the Yetus annotations dependency optional
Given the Yetus dependency is mainly used for documentation
generation and is not used at runtime, we can mark the
annotation as optional for users consuming Kudu.
This is similar to the jsr305 dependency which we mark
as optional.
Additionally we don’t need to include Yetus in our shaded
jars.
Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Reviewed-on: http://gerrit.cloudera.org:8080/10095
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
14 files changed, 55 insertions(+), 41 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 )
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 19 Apr 2018 17:31:06 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 )
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
Patch Set 5: Code-Review+2
Carrying the +2 through the rebase.
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 20 Apr 2018 03:24:29 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 )
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 19 Apr 2018 20:08:16 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Mark the Yetus annotations dependency optional
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 )
Change subject: [Java] Mark the Yetus annotations dependency optional
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6daf4f21c6cdde08145f5467e84d68dbe40cec16
Gerrit-Change-Number: 10095
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 19 Apr 2018 16:59:25 +0000
Gerrit-HasComments: No