You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Gavin (JIRA)" <ji...@apache.org> on 2005/08/07 12:17:35 UTC

[jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

    [ http://issues.apache.org/jira/browse/FOR-605?page=comments#action_12317899 ] 

Gavin commented on FOR-605:
---------------------------

I removed the comment tags from the motd in /forrest/site-author/skinconf.xml but it has made no difference.
Can you tell me how to enable motd so I can check it out.

Looking at http://forrest.apache.org/pluginDocs/plugins_0_80/index.html where it displays correctly it is a width problem somewhere.

Due to long URL description links on pages that have motd also, this would probably be unresolvable with motd in its current position, CSS or not. 

Moving motd above or below might be a better idea, but I'll have a play and let you see what I come up with.

Gav...

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: 605-screenshot.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav...." <br...@brightontown.com.au>.
----- Original Message ----- 
From: "David Crossley" <cr...@apache.org>

| >Gav Wrote:
| > How about changing this example code to something that IS provided by
| > default,
| > maybe 'plugins_0_70' and 'plugins_0_80' or something ?
|
| Please send a patch to main/fresh-site/src/documentation/skinconf.xml

patch uploaded, seemed appropraite to create sub-task of FOR-605.
|
| > Also , I notice that the motd-option pattern does filenames as well as
| > recursive
| > handling of directory names.
|
| Well, it is just any pattern.

True, I haven't checked but can there be a != pattern too (anywhere but ...)

|
| > e.g. - 'index' will put a motd on every index.html page on the site.
| > e.g - 'samples' will put a motd on every page of every sub-directory of
| > /samples/
|
| Careful, that would also match a file at the top level
| called mysamplesfoo.html

So it does.
|
| > Is this documented anywhere?
|
| The only documentation is what you see in the skinconf.xml

Ok, I started a very brief doc of MOTD in the faq as a new entry, this
can be expanded on if need be with more code examples maybe.

Hopefully this will help answer the question such as that raised on the user 
list
earlier today.

Gav... 



-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.10.16/83 - Release Date: 26/08/2005


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
>
> Anyway, I 'thought' it would just work as-is and never noticed until close 
> inspection
> that the example code given will not work unless altered to a valid provided 
> URI.
> The example code gives 'docs_0_70' and 'docs_0_80' as example pattern 
> strings.
> With the default seed site that is created howver, this uri's do not exist 
> and was
> where I was originally getting confused and wondering why it would not work.
> 
> How about changing this example code to something that IS provided by 
> default,
> maybe 'plugins_0_70' and 'plugins_0_80' or something ?

Okay, keep the defaults as simple as possible.
Perhaps "samples" as you suggest below.

Please send a patch to main/fresh-site/src/documentation/skinconf.xml

> Also , I notice that the motd-option pattern does filenames as well as 
> recursive
> handling of directory names.

Well, it is just any pattern.

> e.g. - 'index' will put a motd on every index.html page on the site.
> e.g - 'samples' will put a motd on every page of every sub-directory of 
> /samples/

Careful, that would also match a file at the top level
called mysamplesfoo.html

> Is this documented anywhere?

The only documentation is what you see in the skinconf.xml

> | Anything that you can do to improve that, or even do
> | somthing completely different, would be good.
> 
> Ok, no problem, will do. Below the menu where it is now as one location is 
> great
> as it is. The other one on the main motd-area I will shift to the right a 
> bit and remove
> some padding etc in surrounding areas and see if that improves things before 
> I
> think about putting it anywhere else, the current location makes sense.

Okay, one step at a time.

-David

Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav...." <br...@brightontown.com.au>.
----- Original Message ----- 
From: "David Crossley"

|
| The MOTD is explained in a 'seed' site skinconf.xml
| You need to define a pattern for it to match the uri.

Yep, got it thanks. This is where I was enabling it by uncommenting the MOTD 
section.
(At least when I tried to do this at the beginning of August it was 
commented out by
default, a new seed site a just did seemed to have it enabled by default 
this time.)

Anyway, I 'thought' it would just work as-is and never noticed until close 
inspection
that the example code given will not work unless altered to a valid provided 
URI.
The example code gives 'docs_0_70' and 'docs_0_80' as example pattern 
strings.
With the default seed site that is created howver, this uri's do not exist 
and was
where I was originally getting confused and wondering why it would not work.

How about changing this example code to something that IS provided by 
default,
maybe 'plugins_0_70' and 'plugins_0_80' or something ?

Also , I notice that the motd-option pattern does filenames as well as 
recursive
handling of directory names.

e.g. - 'index' will put a motd on every index.html page on the site.
e.g - 'samples' will put a motd on every page of every sub-directory of 
/samples/

Is this documented anywhere?

|
| Looking at /forrest/site-author/skinconf.xml the MOTD
| is already enabled, so i am not sure what your question is.

Ignore that, I got my skinconf's mixed up.

|
| > Looking at http://forrest.apache.org/pluginDocs/plugins_0_80/index.html 
where it displays correctly it is a width problem somewhere.
| >
| > Due to long URL description links on pages that have motd also, this 
would probably be unresolvable with motd in its current position, CSS or 
not.
| >
| > Moving motd above or below might be a better idea, but I'll have a play 
and let you see what I come up with.
|
| The main idea was to be able to display a
| short message in a prominent place.
|
| There is often whitespace on the left of the
| table of contents. However, my implementation
| was not very good.
|
| Anything that you can do to improve that, or even do
| somthing completely different, would be good.

Ok, no problem, will do. Below the menu where it is now as one location is 
great
as it is. The other one on the main motd-area I will shift to the right a 
bit and remove
some padding etc in surrounding areas and see if that improves things before 
I
think about putting it anywhere else, the current location makes sense.

Gav... 



-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.10.15/80 - Release Date: 23/08/2005


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
Gavin (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/FOR-605?page=comments#action_12317899 ] 
> 
> Gavin commented on FOR-605:
> ---------------------------
> 
> I removed the comment tags from the motd in /forrest/site-author/skinconf.xml but it has made no difference.
> Can you tell me how to enable motd so I can check it out.

Please ask questions on the mailing list rather than
the issue tracker. Keep the latter as concise as possible.

The MOTD is explained in a 'seed' site skinconf.xml
You need to define a pattern for it to match the uri.

Looking at /forrest/site-author/skinconf.xml the MOTD
is already enabled, so i am not sure what your question is.

> Looking at http://forrest.apache.org/pluginDocs/plugins_0_80/index.html where it displays correctly it is a width problem somewhere.
> 
> Due to long URL description links on pages that have motd also, this would probably be unresolvable with motd in its current position, CSS or not. 
> 
> Moving motd above or below might be a better idea, but I'll have a play and let you see what I come up with.

The main idea was to be able to display a
short message in a prominent place.

There is often whitespace on the left of the
table of contents. However, my implementation
was not very good.

Anything that you can do to improve that, or even do
somthing completely different, would be good.

-David