You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/01/30 15:08:48 UTC
Review Request 69862: Validated static framework offer filters.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description
-------
Validated static framework offer filters.
Diffs
-----
src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb
src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e
src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861
src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741
Diff: https://reviews.apache.org/r/69862/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69862: Validated static framework offer filters.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/#review212490
-----------------------------------------------------------
Fix it, then Ship it!
src/common/validation.cpp
Lines 629-632 (patched)
<https://reviews.apache.org/r/69862/#comment298250>
Should we also disallow NaN and +inf? (along with tests for these cases?)
- Benjamin Mahler
On Jan. 31, 2019, 3:15 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69862/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2019, 3:15 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds validation to framework-specified static offer filters.
> In particular we enforce that minimal resource quantities cannot be
> negative.
>
>
> Diffs
> -----
>
> src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb
> src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e
> src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861
> src/master/validation.cpp 7e688bb657cd44f98f082b5efe7178edcb7ce595
> src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779
> src/tests/master_validation_tests.cpp c00e8bb315c28bdf438da2089dd81f5e348982e5
>
>
> Diff: https://reviews.apache.org/r/69862/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69862: Validated static framework offer filters.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/#review212834
-----------------------------------------------------------
src/common/validation.cpp
Lines 622-625 (patched)
<https://reviews.apache.org/r/69862/#comment298726>
Hm.. this should be allowed? This is how the framework can express an override of the global min with no minimum
src/common/validation.cpp
Lines 630-632 (patched)
<https://reviews.apache.org/r/69862/#comment298725>
this seems good!
Maybe also a comment:
```
We disallow an empty quantity since that is equivalent to an empty set (i.e. override of "no minimum")
```
- Benjamin Mahler
On Feb. 13, 2019, 10:31 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69862/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2019, 10:31 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds validation to framework-specified static offer filters.
> In particular we enforce that minimal resource quantities cannot be
> negative.
>
>
> Diffs
> -----
>
> src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb
> src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e
> src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861
> src/master/validation.cpp 4a699f06a3e47ff50b356ce6ff470d1c4e13b02e
> src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779
> src/tests/master_validation_tests.cpp b34e88f12a8959989aea5c180b15f8ae2933d33f
>
>
> Diff: https://reviews.apache.org/r/69862/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69862: Validated static framework offer filters.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/#review212840
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 14, 2019, 8:46 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69862/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2019, 8:46 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds validation to framework-specified static offer filters.
> In particular we enforce that minimal resource quantities cannot be
> negative.
>
>
> Diffs
> -----
>
> src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb
> src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e
> src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861
> src/master/validation.cpp 4a699f06a3e47ff50b356ce6ff470d1c4e13b02e
> src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779
> src/tests/master_validation_tests.cpp b34e88f12a8959989aea5c180b15f8ae2933d33f
>
>
> Diff: https://reviews.apache.org/r/69862/diff/5/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69862: Validated static framework offer filters.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/
-----------------------------------------------------------
(Updated Feb. 14, 2019, 9:46 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Allow empty set of min allocatable quantities
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description
-------
This patch adds validation to framework-specified static offer filters.
In particular we enforce that minimal resource quantities cannot be
negative.
Diffs (updated)
-----
src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb
src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e
src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861
src/master/validation.cpp 4a699f06a3e47ff50b356ce6ff470d1c4e13b02e
src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779
src/tests/master_validation_tests.cpp b34e88f12a8959989aea5c180b15f8ae2933d33f
Diff: https://reviews.apache.org/r/69862/diff/5/
Changes: https://reviews.apache.org/r/69862/diff/4-5/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69862: Validated static framework offer filters.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/
-----------------------------------------------------------
(Updated Feb. 13, 2019, 11:31 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Disallow empty quantities in min. allocatable resources, or empty quantities itself, https://reviews.apache.org/r/69890/#comment298526
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description
-------
This patch adds validation to framework-specified static offer filters.
In particular we enforce that minimal resource quantities cannot be
negative.
Diffs (updated)
-----
src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb
src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e
src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861
src/master/validation.cpp 4a699f06a3e47ff50b356ce6ff470d1c4e13b02e
src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779
src/tests/master_validation_tests.cpp b34e88f12a8959989aea5c180b15f8ae2933d33f
Diff: https://reviews.apache.org/r/69862/diff/4/
Changes: https://reviews.apache.org/r/69862/diff/3-4/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69862: Validated static framework offer filters.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/
-----------------------------------------------------------
(Updated Feb. 4, 2019, 12:14 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Add validation to exclude NaN and inf values
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description
-------
This patch adds validation to framework-specified static offer filters.
In particular we enforce that minimal resource quantities cannot be
negative.
Diffs (updated)
-----
src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb
src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e
src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861
src/master/validation.cpp 7e688bb657cd44f98f082b5efe7178edcb7ce595
src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779
src/tests/master_validation_tests.cpp c00e8bb315c28bdf438da2089dd81f5e348982e5
Diff: https://reviews.apache.org/r/69862/diff/3/
Changes: https://reviews.apache.org/r/69862/diff/2-3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69862: Validated static framework offer filters.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/
-----------------------------------------------------------
(Updated Jan. 31, 2019, 4:15 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Add more tests.
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description (updated)
-------
This patch adds validation to framework-specified static offer filters.
In particular we enforce that minimal resource quantities cannot be
negative.
Diffs (updated)
-----
src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb
src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e
src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861
src/master/validation.cpp 7e688bb657cd44f98f082b5efe7178edcb7ce595
src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779
src/tests/master_validation_tests.cpp c00e8bb315c28bdf438da2089dd81f5e348982e5
Diff: https://reviews.apache.org/r/69862/diff/2/
Changes: https://reviews.apache.org/r/69862/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier