You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/25 00:53:43 UTC
[GitHub] [hudi] alexeykudinkin opened a new pull request, #5970: [WIP] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
alexeykudinkin opened a new pull request, #5970:
URL: https://github.com/apache/hudi/pull/5970
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
Currently after #4253 no matter whether the user specified it explicitly or was relying on a default value this config value will be overridden (ie potentially reverting what have been specified by the user). As such, there's no way presently to enforce this config on the write side if your schema contains `DecimalType` fitting into the range.
Instead the behavior should be to only override _default_ config value in cases when there's a `DecimalType` of expected range, and if this config have been specified by the user -- it should not be overridden.
## Brief change log
- Fixed sequence determining whether Parquet's legacy-format writing property should be overridden to only kick in when it has not been explicitly specified by the caller;
- Fixed tests
## Verify this pull request
This pull request is already covered by existing tests, such as *(please describe tests)*.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1166191046
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"triggerType" : "PUSH"
}, {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "1166186291",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6fbc44d2971dee69216b57c77dd6c853d768fb60 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1166165607
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6fbc44d2971dee69216b57c77dd6c853d768fb60 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1168154277
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"triggerType" : "PUSH"
}, {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "1166186291",
"triggerType" : "MANUAL"
}, {
"hash" : "58d8e2c3b262ffa7263297d141e5c8d5d1690136",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9598",
"triggerID" : "58d8e2c3b262ffa7263297d141e5c8d5d1690136",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6fbc44d2971dee69216b57c77dd6c853d768fb60 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524)
* 58d8e2c3b262ffa7263297d141e5c8d5d1690136 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9598)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1168151901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"triggerType" : "PUSH"
}, {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "1166186291",
"triggerType" : "MANUAL"
}, {
"hash" : "58d8e2c3b262ffa7263297d141e5c8d5d1690136",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "58d8e2c3b262ffa7263297d141e5c8d5d1690136",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6fbc44d2971dee69216b57c77dd6c853d768fb60 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524)
* 58d8e2c3b262ffa7263297d141e5c8d5d1690136 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #5970: [WIP] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #5970:
URL: https://github.com/apache/hudi/pull/5970#discussion_r906613435
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java:
##########
@@ -327,14 +326,40 @@ public static HiveSyncConfig buildHiveSyncConfig(TypedProperties props, String b
return hiveSyncConfig;
}
- // Now by default ParquetWriteSupport will write DecimalType to parquet as int32/int64 when the scale of decimalType < Decimal.MAX_LONG_DIGITS(),
- // but AvroParquetReader which used by HoodieParquetReader cannot support read int32/int64 as DecimalType.
- // try to find current schema whether contains that DecimalType, and auto set the value of "hoodie.parquet.writelegacyformat.enabled"
- public static void mayBeOverwriteParquetWriteLegacyFormatProp(Map<String, String> properties, StructType schema) {
- if (DataTypeUtils.foundSmallPrecisionDecimalType(schema)
- && !Boolean.parseBoolean(properties.getOrDefault(HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED.key(), "false"))) {
- properties.put(HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED.key(), "true");
- LOG.warn("Small Decimal Type found in current schema, auto set the value of hoodie.parquet.writelegacyformat.enabled to true");
+
+ /**
+ * Checks whether default value (false) of "hoodie.parquet.writelegacyformat.enabled" should be
+ * overridden in case:
+ *
+ * <ul>
+ * <li>Property has not been explicitly set by the writer</li>
+ * <li>Data schema contains {@code DecimalType} that would be affected by it</li>
+ * </ul>
+ *
+ * If both of the aforementioned conditions are true, will override the default value of the config
+ * (by essentially setting the value) to make sure that the produced Parquet data files could be
+ * read by {@code AvroParquetReader}
+ *
+ * @param properties properties specified by the writer
+ * @param schema schema of the dataset being written
+ */
+ public static void tryOverrideParquetWriteLegacyFormatProperty(Map<String, String> properties, StructType schema) {
+ if (DataTypeUtils.hasSmallPrecisionDecimalType(schema)) {
Review Comment:
minor. why not do cond1 && cond2 instead of "if" within an "if" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #5970:
URL: https://github.com/apache/hudi/pull/5970#discussion_r906615428
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java:
##########
@@ -327,14 +326,40 @@ public static HiveSyncConfig buildHiveSyncConfig(TypedProperties props, String b
return hiveSyncConfig;
}
- // Now by default ParquetWriteSupport will write DecimalType to parquet as int32/int64 when the scale of decimalType < Decimal.MAX_LONG_DIGITS(),
- // but AvroParquetReader which used by HoodieParquetReader cannot support read int32/int64 as DecimalType.
- // try to find current schema whether contains that DecimalType, and auto set the value of "hoodie.parquet.writelegacyformat.enabled"
- public static void mayBeOverwriteParquetWriteLegacyFormatProp(Map<String, String> properties, StructType schema) {
- if (DataTypeUtils.foundSmallPrecisionDecimalType(schema)
- && !Boolean.parseBoolean(properties.getOrDefault(HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED.key(), "false"))) {
- properties.put(HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED.key(), "true");
- LOG.warn("Small Decimal Type found in current schema, auto set the value of hoodie.parquet.writelegacyformat.enabled to true");
+
+ /**
+ * Checks whether default value (false) of "hoodie.parquet.writelegacyformat.enabled" should be
+ * overridden in case:
+ *
+ * <ul>
+ * <li>Property has not been explicitly set by the writer</li>
+ * <li>Data schema contains {@code DecimalType} that would be affected by it</li>
+ * </ul>
+ *
+ * If both of the aforementioned conditions are true, will override the default value of the config
+ * (by essentially setting the value) to make sure that the produced Parquet data files could be
+ * read by {@code AvroParquetReader}
+ *
+ * @param properties properties specified by the writer
+ * @param schema schema of the dataset being written
+ */
+ public static void tryOverrideParquetWriteLegacyFormatProperty(Map<String, String> properties, StructType schema) {
+ if (DataTypeUtils.hasSmallPrecisionDecimalType(schema)) {
Review Comment:
Good catch! Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1166190586
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"triggerType" : "PUSH"
}, {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1166186291",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6fbc44d2971dee69216b57c77dd6c853d768fb60 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1166186291
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1166182925
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6fbc44d2971dee69216b57c77dd6c853d768fb60 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1166186163
@xiarixiaoyao yeah, i'm aware of that. This is simply changing it such that if this config is specified by the user explicitly (for whatever reason) it would respect that instead of forcing it possibly the other way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1166167477
@alexeykudinkin @nsivabalan
why add this condition ？
if Small Decimal Type found in the persisted schema, and 'hoodie.parquet.writelegacyformat.enabled' is set to false
hoodie will write a data wich cannot be read by AvroParquetReader
see TestCase TestCOWDataSource. testWriteSmallPrecisionDecimalTable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
yihua merged PR #5970:
URL: https://github.com/apache/hudi/pull/5970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1168303769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"triggerType" : "PUSH"
}, {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9524",
"triggerID" : "1166186291",
"triggerType" : "MANUAL"
}, {
"hash" : "58d8e2c3b262ffa7263297d141e5c8d5d1690136",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9598",
"triggerID" : "58d8e2c3b262ffa7263297d141e5c8d5d1690136",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 58d8e2c3b262ffa7263297d141e5c8d5d1690136 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9598)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1166164961
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6fbc44d2971dee69216b57c77dd6c853d768fb60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6fbc44d2971dee69216b57c77dd6c853d768fb60 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #5970: [HUDI-4320] Make sure `HoodieStorageConfig.PARQUET_WRITE_LEGACY_FORMAT_ENABLED` could be specified by the writer
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on PR #5970:
URL: https://github.com/apache/hudi/pull/5970#issuecomment-1166189024
@alexeykudinkin if
> @xiarixiaoyao yeah, i'm aware of that. This is simply changing it such that if this config is specified by the user explicitly (for whatever reason) it would respect that instead of forcing it possibly the other way.
got it， thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org