You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/29 16:51:34 UTC

[GitHub] MaxGekk commented on issue #23409: [SPARK-26502][SQL] Get rid of hiveResultString() in QueryExecution

MaxGekk commented on issue #23409: [SPARK-26502][SQL] Get rid of hiveResultString() in QueryExecution
URL: https://github.com/apache/spark/pull/23409#issuecomment-450505487
 
 
   @hvanhovell I tried to move it to a test class but `hiveResultString` is used `SparkSQLDriver` in `hive-thriftserver`. Having a dependency of a test module in `hive-thriftserver` doesn't look nice. It cannot be moved out of `sql` otherwise we get a cycle in dependencies. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org