You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/02 20:19:41 UTC

[GitHub] [kafka] izzyacademy commented on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

izzyacademy commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-873237780


   @cadonna thanks a lot for your verify detailed explanation and educational feedback. I was not aware of that when I submitted my changes for KIP 633. So I will make a note of that. 
   
   I just have one question. Are these changes only necessary for SessionWindows and TimeWindows classes? What about the JoinWindows and SlidingWindows classes?
   
   Should those be updated as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org