You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/05/01 15:17:43 UTC

[GitHub] rhtyd commented on issue #2601: CLOUDSTACK-10364: Change the "setXXX" method names to "getXXX".

rhtyd commented on issue #2601: CLOUDSTACK-10364: Change the "setXXX" method names to "getXXX".
URL: https://github.com/apache/cloudstack/pull/2601#issuecomment-385697091
 
 
   @DaanHoogland you comment about `get` have been addressed, the author has used a `generate` method name prefix that sounds acceptable (generating a name from params).
   This is a pure method name change, build and Travis have passed. I'll merge this based on these tests and reviews.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services