You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/01/16 02:10:45 UTC

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/
-----------------------------------------------------------

(Updated Jan. 16, 2013, 1:10 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Summary (updated)
-----------------

Standalone stout. Split apart the stout tests into separate files.


Description
-------

This is part 5 of my refactoring to pull apart libprocess / stout tests.

This is the final part, which pulls apart the stout tests.
This makes it easier to spot where our test coverage is insufficient.
There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.


Diffs
-----

  src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 
  src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
  third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 
  third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
  third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
  third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
  third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
  third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
  third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
  third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
  third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
  third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
  third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
  third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
  third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
  third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
  third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
  third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
  third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
  third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
  third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
  third_party/libprocess/include/stout/os.hpp 5b5b33636cb396c3324ab7f3f42144f4ab30ef95 
  third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
  third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0 
  third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
  third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
  third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
  third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
  third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
  third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
  third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
  third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/Makefile.am 3b47c37add67b875303a4586a7ef940c522dafd1 
  third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
  third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/README PRE-CREATION 
  third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
  third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 

Diff: https://reviews.apache.org/r/8796/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Ben Mahler <be...@gmail.com>.


> On Jan. 16, 2013, 7:40 p.m., Vinod Kone wrote:
> > third_party/libprocess/third_party/stout/m4/ltoptions.m4, line 84
> > <https://reviews.apache.org/r/8796/diff/2/?file=248741#file248741line84>
> >
> >     ws

Dropped the m4 stuff since we don't own those files.


> On Jan. 16, 2013, 7:40 p.m., Vinod Kone wrote:
> > third_party/libprocess/third_party/stout/m4/lt~obsolete.m4, line 28
> > <https://reviews.apache.org/r/8796/diff/2/?file=248744#file248744line28>
> >
> >     ws

Ditto


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/#review15399
-----------------------------------------------------------


On Jan. 16, 2013, 1:10 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8796/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 1:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This is part 5 of my refactoring to pull apart libprocess / stout tests.
> 
> This is the final part, which pulls apart the stout tests.
> This makes it easier to spot where our test coverage is insufficient.
> There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 
>   src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
>   third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 
>   third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
>   third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
>   third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
>   third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
>   third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
>   third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
>   third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
>   third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
>   third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
>   third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
>   third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
>   third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
>   third_party/libprocess/include/stout/os.hpp 5b5b33636cb396c3324ab7f3f42144f4ab30ef95 
>   third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
>   third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0 
>   third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
>   third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
>   third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
>   third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
>   third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
>   third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
>   third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
>   third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/Makefile.am 3b47c37add67b875303a4586a7ef940c522dafd1 
>   third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
>   third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/README PRE-CREATION 
>   third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
>   third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8796/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/#review15399
-----------------------------------------------------------

Ship it!



third_party/libprocess/third_party/stout/Makefile.am
<https://reviews.apache.org/r/8796/#comment33156>

    s/libprocess/stout/



third_party/libprocess/third_party/stout/configure.ac
<https://reviews.apache.org/r/8796/#comment33160>

    This sentence doesn't make sense inside of stout?



third_party/libprocess/third_party/stout/m4/ltoptions.m4
<https://reviews.apache.org/r/8796/#comment33162>

    ws



third_party/libprocess/third_party/stout/m4/lt~obsolete.m4
<https://reviews.apache.org/r/8796/#comment33164>

    ws



third_party/libprocess/third_party/stout/third_party/Makefile.am
<https://reviews.apache.org/r/8796/#comment33165>

    s/needed//


- Vinod Kone


On Jan. 16, 2013, 1:10 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8796/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 1:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This is part 5 of my refactoring to pull apart libprocess / stout tests.
> 
> This is the final part, which pulls apart the stout tests.
> This makes it easier to spot where our test coverage is insufficient.
> There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 
>   src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
>   third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 
>   third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
>   third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
>   third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
>   third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
>   third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
>   third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
>   third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
>   third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
>   third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
>   third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
>   third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
>   third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
>   third_party/libprocess/include/stout/os.hpp 5b5b33636cb396c3324ab7f3f42144f4ab30ef95 
>   third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
>   third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0 
>   third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
>   third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
>   third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
>   third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
>   third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
>   third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
>   third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
>   third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/Makefile.am 3b47c37add67b875303a4586a7ef940c522dafd1 
>   third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
>   third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/README PRE-CREATION 
>   third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
>   third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8796/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/#review17060
-----------------------------------------------------------



third_party/libprocess/Makefile.am
<https://reviews.apache.org/r/8796/#comment36118>

    These shouldn't be included in both libprocess and stout ... that would produce a weird distribution.


- Benjamin Hindman


On Feb. 1, 2013, 11:56 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8796/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 11:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This is part 5 of my refactoring to pull apart libprocess / stout tests.
> 
> This is the final part, which pulls apart the stout tests.
> This makes it easier to spot where our test coverage is insufficient.
> There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 
>   src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
>   third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325 
>   third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
>   third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
>   third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
>   third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
>   third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
>   third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
>   third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
>   third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
>   third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
>   third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
>   third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
>   third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
>   third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
>   third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
>   third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
>   third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
>   third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
>   third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
>   third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/Makefile.am 58ebb293d6b687cfd7daf5343c4b3c3c9e47bf0c 
>   third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
>   third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/README PRE-CREATION 
>   third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
>   third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8796/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Ben Mahler <be...@gmail.com>.


> On Feb. 25, 2013, 10:02 p.m., Benjamin Hindman wrote:
> >

As discussed, leaving these for you to clean up on a secondary commit.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/#review17061
-----------------------------------------------------------


On Feb. 1, 2013, 11:56 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8796/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 11:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This is part 5 of my refactoring to pull apart libprocess / stout tests.
> 
> This is the final part, which pulls apart the stout tests.
> This makes it easier to spot where our test coverage is insufficient.
> There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 
>   src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
>   third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325 
>   third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
>   third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
>   third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
>   third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
>   third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
>   third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
>   third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
>   third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
>   third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
>   third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
>   third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
>   third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
>   third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
>   third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
>   third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
>   third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
>   third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
>   third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
>   third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/Makefile.am 58ebb293d6b687cfd7daf5343c4b3c3c9e47bf0c 
>   third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
>   third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/README PRE-CREATION 
>   third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
>   third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8796/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/#review17061
-----------------------------------------------------------



third_party/libprocess/third_party/stout/m4/libtool.m4
<https://reviews.apache.org/r/8796/#comment36120>

    All of the *.m4 files that you included are actually generated and shouldn't be part of the repository.


- Benjamin Hindman


On Feb. 1, 2013, 11:56 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8796/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 11:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This is part 5 of my refactoring to pull apart libprocess / stout tests.
> 
> This is the final part, which pulls apart the stout tests.
> This makes it easier to spot where our test coverage is insufficient.
> There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 
>   src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
>   third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325 
>   third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
>   third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
>   third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
>   third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
>   third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
>   third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
>   third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
>   third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
>   third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
>   third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
>   third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
>   third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
>   third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
>   third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
>   third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
>   third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
>   third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
>   third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
>   third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/Makefile.am 58ebb293d6b687cfd7daf5343c4b3c3c9e47bf0c 
>   third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
>   third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/README PRE-CREATION 
>   third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
>   third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8796/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/
-----------------------------------------------------------

(Updated Feb. 1, 2013, 11:56 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased off trunk.


Description
-------

This is part 5 of my refactoring to pull apart libprocess / stout tests.

This is the final part, which pulls apart the stout tests.
This makes it easier to spot where our test coverage is insufficient.
There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.


Diffs (updated)
-----

  src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 
  src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
  third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325 
  third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
  third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
  third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
  third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
  third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
  third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
  third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
  third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
  third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
  third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
  third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
  third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
  third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
  third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
  third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
  third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
  third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
  third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
  third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
  third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
  third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
  third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
  third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
  third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
  third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
  third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
  third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
  third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
  third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/Makefile.am 58ebb293d6b687cfd7daf5343c4b3c3c9e47bf0c 
  third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
  third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/README PRE-CREATION 
  third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
  third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 

Diff: https://reviews.apache.org/r/8796/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Ben Mahler <be...@gmail.com>.


> On Jan. 30, 2013, 8:26 p.m., Benjamin Hindman wrote:
> > I'd like to address the proliferation of copies of tarballs in third_party before we continue on here. Ideally stout is independent, but perhaps it requires more explicit configuration that gets set up when it is embedded in libprocess/mesos? Or perhaps libprocess and mesos use third_party in stout? I imagine we should discuss the pros/cons of different strategies.

(1) I was leaning towards your point of:
  -libprocess / mesos using third_party in stout
  -mesos using third_party in libprocess (only needed to de-dup the gperftools-2.0.tar.gz)

But dodged this since it requires some restructuring of the Makefiles.
If you're worried about stout not being standalone: Stout distributions could only include the headers, and the stout repository could contain the third_party files needed for tests.

(2) The alternative of having stout completely standalone, has the large disadvantage that the stout tests will not be able to run on their own.
This disadvantage makes this alternative seem pretty bad IMO.

Are you ok with (1)? Are there other options / tricks that eliminate the tar.gz duplication?


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/#review15885
-----------------------------------------------------------


On Jan. 29, 2013, 1:53 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8796/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 1:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This is part 5 of my refactoring to pull apart libprocess / stout tests.
> 
> This is the final part, which pulls apart the stout tests.
> This makes it easier to spot where our test coverage is insufficient.
> There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 
>   src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
>   third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 
>   third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
>   third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
>   third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
>   third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
>   third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
>   third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
>   third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
>   third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
>   third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
>   third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
>   third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
>   third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
>   third_party/libprocess/include/stout/os.hpp fdba9cadc38251b192e9d395a0a1ab1f08327596 
>   third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
>   third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0 
>   third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
>   third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
>   third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
>   third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
>   third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
>   third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
>   third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
>   third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/Makefile.am 3b47c37add67b875303a4586a7ef940c522dafd1 
>   third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
>   third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/README PRE-CREATION 
>   third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
>   third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8796/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/#review15885
-----------------------------------------------------------


I'd like to address the proliferation of copies of tarballs in third_party before we continue on here. Ideally stout is independent, but perhaps it requires more explicit configuration that gets set up when it is embedded in libprocess/mesos? Or perhaps libprocess and mesos use third_party in stout? I imagine we should discuss the pros/cons of different strategies.

- Benjamin Hindman


On Jan. 29, 2013, 1:53 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8796/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 1:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This is part 5 of my refactoring to pull apart libprocess / stout tests.
> 
> This is the final part, which pulls apart the stout tests.
> This makes it easier to spot where our test coverage is insufficient.
> There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 
>   src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
>   third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 
>   third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
>   third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
>   third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
>   third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
>   third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
>   third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
>   third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
>   third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
>   third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
>   third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
>   third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
>   third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
>   third_party/libprocess/include/stout/os.hpp fdba9cadc38251b192e9d395a0a1ab1f08327596 
>   third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
>   third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0 
>   third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
>   third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
>   third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
>   third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
>   third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
>   third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
>   third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
>   third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/Makefile.am 3b47c37add67b875303a4586a7ef940c522dafd1 
>   third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
>   third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/README PRE-CREATION 
>   third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
>   third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8796/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/
-----------------------------------------------------------

(Updated Jan. 29, 2013, 1:53 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased off trunk.


Description
-------

This is part 5 of my refactoring to pull apart libprocess / stout tests.

This is the final part, which pulls apart the stout tests.
This makes it easier to spot where our test coverage is insufficient.
There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.


Diffs (updated)
-----

  src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 
  src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
  third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 
  third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
  third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
  third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
  third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
  third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
  third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
  third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
  third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
  third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
  third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
  third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
  third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
  third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
  third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
  third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
  third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
  third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
  third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
  third_party/libprocess/include/stout/os.hpp fdba9cadc38251b192e9d395a0a1ab1f08327596 
  third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
  third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0 
  third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
  third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
  third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
  third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
  third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
  third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
  third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
  third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/Makefile.am 3b47c37add67b875303a4586a7ef940c522dafd1 
  third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
  third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/README PRE-CREATION 
  third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
  third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 

Diff: https://reviews.apache.org/r/8796/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/
-----------------------------------------------------------

(Updated Jan. 16, 2013, 11:24 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

vinod's review


Description
-------

This is part 5 of my refactoring to pull apart libprocess / stout tests.

This is the final part, which pulls apart the stout tests.
This makes it easier to spot where our test coverage is insufficient.
There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.


Diffs
-----

  src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 
  src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
  third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 
  third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
  third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
  third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
  third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
  third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
  third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
  third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
  third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
  third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
  third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
  third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
  third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
  third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
  third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
  third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
  third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
  third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
  third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
  third_party/libprocess/include/stout/os.hpp 5b5b33636cb396c3324ab7f3f42144f4ab30ef95 
  third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
  third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0 
  third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
  third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
  third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
  third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
  third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
  third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
  third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
  third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/Makefile.am 3b47c37add67b875303a4586a7ef940c522dafd1 
  third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
  third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/README PRE-CREATION 
  third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
  third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 

Diff: https://reviews.apache.org/r/8796/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Standalone stout. Split apart the stout tests into separate files.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8796/
-----------------------------------------------------------

(Updated Jan. 16, 2013, 11:24 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

This is part 5 of my refactoring to pull apart libprocess / stout tests.

This is the final part, which pulls apart the stout tests.
This makes it easier to spot where our test coverage is insufficient.
There are no real diffs on these *tests.cpp files, since I just pulled the contents of stout_tests.cpp apart.


Diffs (updated)
-----

  src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 
  src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 
  third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 
  third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75 
  third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
  third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1f10aafabaaec47e7dfc 
  third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beead822fdcb19981 
  third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841523c4e5c7ffad4 
  third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600c50f81839e9b4c91 
  third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3a6be87b37698f28f0 
  third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
  third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c772945cc2a8b73f8b01 
  third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
  third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d5c6006f1a45cb4d0 
  third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3 
  third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45 
  third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0cfe87faa2e991bf074b38d50 
  third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525bb3c741d5ad436 
  third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188b100576b340ab71a 
  third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
  third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca 
  third_party/libprocess/include/stout/os.hpp 5b5b33636cb396c3324ab7f3f42144f4ab30ef95 
  third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005132634c7912e0 
  third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0 
  third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f501135e67804c335 
  third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16e9bf49a3ef235f19d5 
  third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc5659b166e92380be0bca 
  third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd 
  third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee70abeca322fab 
  third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d91459525739edd53d150 
  third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805ada0a8ba7d14c 
  third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/Makefile.am 3b47c37add67b875303a4586a7ef940c522dafd1 
  third_party/libprocess/third_party/stout/LICENSE PRE-CREATION 
  third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/README PRE-CREATION 
  third_party/libprocess/third_party/stout/bootstrap PRE-CREATION 
  third_party/libprocess/third_party/stout/configure.ac PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/stout/third_party/versions.am PRE-CREATION 

Diff: https://reviews.apache.org/r/8796/diff/


Testing
-------

make check


Thanks,

Ben Mahler