Re: [PR] GH-2870: Report compressed dictionary page sizes in the CLI [parquet-java]

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #3798:
URL: https://github.com/apache/parquet-java/pull/3798#discussion_r4240420541


##########
parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowPagesCommand.java:
##########
@@ -229,9 +229,7 @@ private long getPageCompressedSize() {
     }
 
     private String printDictionaryPage(DictionaryPage dict) {
-      // TODO: the compressed size of a dictionary page is lost in Parquet
-      dict.getUncompressedSize();
-      long totalSize = dict.getCompressedSize();
+      long totalSize = getPageCompressedSize();

Review Comment:
   At least this change is not worse than before. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org