[jira] [Closed] (OFBIZ-11448) Potential Nullpointer in ErrorPage.ftl

["Michael Brohl (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Brohl closed OFBIZ-11448.
---------------------------------
    Fix Version/s: 17.12.02
                   18.12.01
       Resolution: Fixed

Thanks Dennis Balkir,

this is committed in trunk and backported to release branches 17.12, 18.12.

> Potential Nullpointer in ErrorPage.ftl
> --------------------------------------
>
>                 Key: OFBIZ-11448
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11448
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>            Reporter: Dennis Balkir
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: 18.12.01, 17.12.02
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This line of code right here:
> {code:java}
> <p>${request.getAttribute("_ERROR_MESSAGE_")?replace("\n", "<br/>")}</p>
> {code}
> can produce a nullpointer error, since the attribute "_ERROR_MESSAGE_" from the request ist used by the replace method of freemarker, without nullchecking it first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)