You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by SeanTAllen <gi...@git.apache.org> on 2014/11/08 15:45:59 UTC
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
GitHub user SeanTAllen opened a pull request:
https://github.com/apache/storm/pull/309
STORM-549: "topology.enable.message.timeouts" does nothing
The ability to turn off message timeouts doesn't work.
The value is a true/false value that is represented as
a Java Boolean. The check for the truthiness used the
clojure not function. The idea was, turn off message
timeouts if "topology.enable.message.timeouts" is not true.
Unfortunately this won't worth with clojure's definition of
truthiness as:
(not (Boolean. false))
evaluates to true.
This commit updates the logic to compare the Java Boolean
"topology.enable.message.timeouts" to false using the
= function which will work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SeanTAllen/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit 0505d47471170861ad303dc530a8d8de4e730c10
Author: Sean T Allen <se...@monkeysnatchbanana.com>
Date: 2014-11-08T14:41:29Z
STORM-549: "topology.enable.message.timeouts" does nothing
The ability to turn off message timeouts doesn't work.
The value is a true/false value that is represented as
a Java Boolean. The check for the truthiness used the
clojure not function. The idea was, turn off message
timeouts if "topology.enable.message.timeouts" is not true.
Unfortunately this won't worth with clojure's definition of
truthiness as:
(not (Boolean. false))
evaluates to true.
This commit updates the logic to compare the Java Boolean
"topology.enable.message.timeouts" to false using the
= function which will work.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
Posted by SeanTAllen <gi...@git.apache.org>.
Github user SeanTAllen commented on the pull request:
https://github.com/apache/storm/pull/309#issuecomment-62290800
@HeartSaVioR done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
Posted by SeanTAllen <gi...@git.apache.org>.
Github user SeanTAllen commented on the pull request:
https://github.com/apache/storm/pull/309#issuecomment-62290760
@HeartSaVioR merge it into my master and update the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/309#issuecomment-62289228
@SeanTAllen @harshach
Hey, I've added unit test to PR branch.
I've confirmed that fails on current master branch of Apache Storm and succeeds on current modification.
Could you check it and merge to reflect current PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
Posted by nathanmarz <gi...@git.apache.org>.
Github user nathanmarz commented on the pull request:
https://github.com/apache/storm/pull/309#issuecomment-63094441
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/309#issuecomment-63092885
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/309#issuecomment-62291331
@SeanTAllen Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/309#issuecomment-63108151
Thanks @SeanTAllen. I merged this into master and 0.9.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/309#issuecomment-62273575
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---