You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/09/28 13:38:48 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #688: revert some scaladoc changes because of scala 2.12 build issues
pjfanning opened a new pull request, #688:
URL: https://github.com/apache/incubator-pekko/pull/688
I've tested this and this revert allows me to publish the pekko-cluster-sharding-typed jar locally while it fails without this revert.
Reverts part of #682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning closed pull request #688: revert some scaladoc changes because of scala 2.12 build issues
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #688: revert some scaladoc changes because of scala 2.12 build issues
URL: https://github.com/apache/incubator-pekko/pull/688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #688: revert some scaladoc changes because of scala 2.12 build issues
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #688:
URL: https://github.com/apache/incubator-pekko/pull/688#issuecomment-1739442134
@pjfanning Wouldn't it be safer to use FQCN rather than just removing the prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #688: revert some scaladoc changes because of scala 2.12 build issues
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #688:
URL: https://github.com/apache/incubator-pekko/pull/688#issuecomment-1739470268
> This is a partial revert of #682 because our builds are broken.
>
> Scaladoc - especially ScalaDoc in Scala 2.12 has bugs. It is a minefield trying to get it right. My main objective is to fix the build. I can't get a build to test the sbt-assembly issue due to the broken build.
I understand, but looking at the diff we are not changing from FQCN to a nested package prefix, rather we are changing from a nested packaged prefix to another nested package prefix.
I am quite sure that if you use a complete FQCN i.e. changing `[[javadsl.Entity]]` to `[[org.apache.pekko.cluster.sharding.typed.javadsl.Entity]]` (or w/e it *should * be) would actually remove all brittleness regarding the scaladoc classname lookup and help prevent future problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #688: revert some scaladoc changes because of scala 2.12 build issues
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #688:
URL: https://github.com/apache/incubator-pekko/pull/688#issuecomment-1739453252
> @pjfanning Wouldn't it be safer to use FQCN rather than just removing the prefix?
This is a partial revert of https://github.com/apache/incubator-pekko/pull/682 because our builds are broken.
Scaladoc - especially ScalaDod in Scala 2.12 has bugs. It is a minefield trying to get it right. My main objective is to fix the build. I can't get a build to test the sbt-assembly issue due to the broken build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #688: revert some scaladoc changes because of scala 2.12 build issues
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #688:
URL: https://github.com/apache/incubator-pekko/pull/688#issuecomment-1739532360
closing in favour of #688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #688: revert some scaladoc changes because of scala 2.12 build issues
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #688:
URL: https://github.com/apache/incubator-pekko/pull/688#issuecomment-1739637863
> closing in favour of #688
@pjfanning I think you forgot to close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org