You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/07/03 19:08:06 UTC
Review Request 67812: Added per-framework offer metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8848
https://issues.apache.org/jira/browse/MESOS-8848
Repository: mesos
Description
-------
Added per-framework offer metrics.
Diffs
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67812/diff/1/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/#review205824
-----------------------------------------------------------
src/master/master.cpp
Lines 4160 (patched)
<https://reviews.apache.org/r/67812/#comment288730>
I think it would be nicer not to increment the counter in the loop, but to use a variable to count the number of accepted offers and then to increment the counter once right after closing this loop.
src/master/master.cpp
Lines 6012 (patched)
<https://reviews.apache.org/r/67812/#comment288731>
Ditto incrementing the counter only one after the loop.
- Gastón Kleiman
On July 6, 2018, 1:52 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67812/
> -----------------------------------------------------------
>
> (Updated July 6, 2018, 1:52 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8848
> https://issues.apache.org/jira/browse/MESOS-8848
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework offer metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67812/diff/2/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/#review206126
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On July 9, 2018, 11:18 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67812/
> -----------------------------------------------------------
>
> (Updated July 9, 2018, 11:18 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8848
> https://issues.apache.org/jira/browse/MESOS-8848
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework offer metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67812/diff/4/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/
-----------------------------------------------------------
(Updated July 24, 2018, 6:01 p.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-8848
https://issues.apache.org/jira/browse/MESOS-8848
Repository: mesos
Description
-------
Added per-framework offer metrics.
Diffs (updated)
-----
src/master/master.cpp 2af976f7ea7f81d4b06a45ce13286dbd61b9b144
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67812/diff/6/
Changes: https://reviews.apache.org/r/67812/diff/5-6/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/#review206227
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On July 17, 2018, 6:34 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67812/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 6:34 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8848
> https://issues.apache.org/jira/browse/MESOS-8848
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework offer metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67812/diff/5/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/
-----------------------------------------------------------
(Updated July 18, 2018, 1:34 a.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-8848
https://issues.apache.org/jira/browse/MESOS-8848
Repository: mesos
Description
-------
Added per-framework offer metrics.
Diffs (updated)
-----
src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67812/diff/5/
Changes: https://reviews.apache.org/r/67812/diff/4-5/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/
-----------------------------------------------------------
(Updated July 9, 2018, 6:18 p.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8848
https://issues.apache.org/jira/browse/MESOS-8848
Repository: mesos
Description
-------
Added per-framework offer metrics.
Diffs (updated)
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67812/diff/4/
Changes: https://reviews.apache.org/r/67812/diff/3-4/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/
-----------------------------------------------------------
(Updated July 6, 2018, 9:49 p.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8848
https://issues.apache.org/jira/browse/MESOS-8848
Repository: mesos
Description
-------
Added per-framework offer metrics.
Diffs (updated)
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67812/diff/3/
Changes: https://reviews.apache.org/r/67812/diff/2-3/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/
-----------------------------------------------------------
(Updated July 6, 2018, 8:52 p.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8848
https://issues.apache.org/jira/browse/MESOS-8848
Repository: mesos
Description
-------
Added per-framework offer metrics.
Diffs (updated)
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67812/diff/2/
Changes: https://reviews.apache.org/r/67812/diff/1-2/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/#review205690
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66882', '66819', '66820', '67808', '67809', '67812']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67812
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67812/logs/mesos-tests-stdout.log):
```
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (803 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (598 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[ OK ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1329 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (797 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (801 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1006 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (601 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[ OK ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5369 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5168 ms)
[----------] 24 tests from DockerContainerizerTest (94967 ms total)
[----------] 1 test from HungDockerTest
[ RUN ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull
d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000D30C8FBDB0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000D30C8FC010.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @0000022D6C6654C8.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @0000022D6DBACA60.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @0000022D6DF8FF80.
ERROR: 5 leaked mock objects found at program exit.
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67812/logs/mesos-tests-stderr.log):
```
I0703 20:54:33.616942 7660 authenticatee.cpp:299] Authentication success
I0703 20:54:33.617961 5816 master.cpp:9819] Successfully authenticated principal 'test-principal' at scheduler-51de20af-9b86-4a1f-92b1-c69446293941@192.10.1.5:52064
I0703 20:54:33.617961 3468 sched.cpp:501] Successfully authenticated with master master@192.10.1.5:52064
I0703 20:54:33.619947 2272 master.cpp:2940] Received SUBSCRIBE call for framework 'default' at scheduler-51de20af-9b86-4a1f-92b1-c69446293941@192.10.1.5:52064
I0703 20:54:33.619947 2272 master.cpp:2241] Authorizing framework principal 'test-principal' to receive offers for roles '{ * }'
I0703 20:54:33.620942 5732 master.cpp:3021] Subscribing framework default with checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 20:54:33.629948 5732 master.cpp:10010] Adding framework 806e0214-fd2c-461f-bf62-ae7ee5f5ebb0-0000 (default) at scheduler-51de20af-9b86-4a1f-92b1-c69446293941@192.10.1.5:52064 with roles { } suppressed
I0703 20:54:33.630949 5816 sched.cpp:749] Framework registered with 806e0214-fd2c-461f-bf62-ae7ee5f5ebb0-0000
I0703 20:54:33.631938 4116 hierarchical.cpp:299] Added framework 806e0214-fd2c-461f-bf62-ae7ee5f5ebb0-0000
E0703 20:54:33.708940 4116 slave.cpp:7289] EXIT with status 1: Failed to perform recovery: Collect failed: Failed to run 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat -H npipe:////./pipe/docker_engine ps -a': exited with status 1; stderr=''C:\Program' is not recognized as an internal or external command,
operable program or batch file.
'
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` flag to a more permissive value.
To restart this agent with a new agent id instead, do as follows:
rm -f C:\Users\jenkins\AppData\Local\Temp\EHZPta\meta\slaves\latest
This ensures that the agent does not recover old live executors.
If you use the Docker containerizer and think that the Docker
daemon state is broken, you can try to clear it. But be careful:
these commands will erase all containers and images from this host,
not just those started by Mesos!
docker kill $(docker ps -q)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)
Finally, restart the agent.
```
- Mesos Reviewbot Windows
On July 3, 2018, 7:08 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67812/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 7:08 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8848
> https://issues.apache.org/jira/browse/MESOS-8848
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework offer metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67812/diff/1/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67812: Added per-framework offer metrics.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/#review205691
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66882, 66819, 66820, 67808, 67809, 67812]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 3, 2018, 12:08 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67812/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 12:08 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8848
> https://issues.apache.org/jira/browse/MESOS-8848
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework offer metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67812/diff/1/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>