You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Paul Rogers (JIRA)" <ji...@apache.org> on 2016/12/19 21:06:58 UTC

[jira] [Resolved] (DRILL-5135) TestMergeJoinWithSchemaChanges.testNumericTypes doesn't

     [ https://issues.apache.org/jira/browse/DRILL-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Rogers resolved DRILL-5135.
--------------------------------
    Resolution: Invalid

Ahem... Turns out that there was an option buried in the query that was not applied at the time test code printed the physical plan...

> TestMergeJoinWithSchemaChanges.testNumericTypes doesn't
> -------------------------------------------------------
>
>                 Key: DRILL-5135
>                 URL: https://issues.apache.org/jira/browse/DRILL-5135
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>
> The test {{TestMergeJoinWithSchemaChanges.testNumericTypes}} claims to test the merge join. However, the test picks up default session options from its base class, {{BaseTestQuery}}, which leaves the hash join enabled. If one inserts code to dump the physical plan for this test, one finds that the test actually uses a hash join, not a merge join.
> The test must be modified to disable hash join. Using the newer test framework:
> {code}
>     FixtureBuilder builder = ClusterFixture.builder()
>         .sessionOption("planner.enable_hashjoin", false)
>         .sessionOption("planner.enable_hashagg", false);
> {code}
> Which produces the following physical plan:
> {code}
>     "pop" : "merge-join",
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)