You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "tdiesler (via GitHub)" <gi...@apache.org> on 2024/10/17 14:46:16 UTC
[PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
tdiesler opened a new pull request, #15998:
URL: https://github.com/apache/camel/pull/15998
https://issues.apache.org/jira/browse/CAMEL-21362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2420197652
> Should this be removed in 4.x as well? It'd be a breaking change.
yeah fine to remove in 4.8.x as its a brand new release and 4.8.0 is a bit buggy here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2420123034
Should this be removed in 4.x as well? It'd be a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2421950357
@davsclaus see https://issues.apache.org/jira/browse/CAMEL-21365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2420582470
LGTM.
A little out of scope but I saw this comment in the code :
https://github.com/apache/camel/blob/f23f02531518c8a2b34a0b5d582a96e81fcd7c42/dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesExport.java#L232-L237
Do you know if there is a lot of diff between jkube, quarkus and generated manifest for labels ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2421651565
@christophd can you create a JIRA with your last comment so we wont forget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2421636778
I think the root cause of all of this is that when using OpenShift as a `cluster-type` we switch from Kubernetes Quarkus extension to the OpenShift Quarkus extension and unfortunately these two seem to behave differently.
The Quarkus Kubernetes extension properly merges the Kubernetes manifest coming from the Camel JBang plugin (in `src/main/kubernetes`) with its own generated Kubernetes manifest. The Quarkus OpenShift extension presumably is not doing the same merger so things like the INTEGRATION_LABEL may not get properly added to the final Kubernetes manifest.
Switching from INTEGRATION_LABEL to KUBERNETES_NAME_LABEL as in this PR fixes it because KUBERNETES_NAME_LABEL is what the Quarkus extension uses. I am fine with the fix in this PR and I also think that is does not break existing behavior since the users coming from 4.8.0 will not face breaking changes because of this as it is an internal detail in the manifest.
In general we need to analyze and find out why the Kubernetes manifest is not merged properly when using the Quarkus OpenShift extension. In 4.8.0 the focus was to support plain Kubernetes where all of this is working properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2419920214
So it seems it needs 2 labels now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #15998:
URL: https://github.com/apache/camel/pull/15998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2422307607
@tdiesler can you update the PR
modified: dsl/camel-jbang/camel-jbang-plugin-k/src/test/java/org/apache/camel/dsl/jbang/core/commands/k/IntegrationExportTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #15998:
URL: https://github.com/apache/camel/pull/15998#discussion_r1805039900
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/traits/BaseTrait.java:
##########
@@ -20,6 +20,7 @@
public abstract class BaseTrait implements Trait {
public static final String INTEGRATION_LABEL = "camel.apache.org/integration";
Review Comment:
Probably you need to remove this then.
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/traits/ContainerTrait.java:
##########
@@ -82,6 +82,7 @@ public void apply(Traits traitConfig, TraitContext context) {
.editOrNewTemplate()
.editOrNewMetadata()
.addToLabels(INTEGRATION_LABEL, context.getName())
Review Comment:
ditto
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/traits/ContainerTrait.java:
##########
@@ -93,6 +94,7 @@ public void apply(Traits traitConfig, TraitContext context) {
.editOrNewJobTemplate()
.editOrNewMetadata()
.addToLabels(INTEGRATION_LABEL, context.getName())
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2420062435
thanks for the review @squakez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21362] camel k8s run cannot find pod on openshift [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #15998:
URL: https://github.com/apache/camel/pull/15998#issuecomment-2421495322
> Should this be removed in 4.x as well? It'd be a breaking change.
It is a valid concern. However, as this is a prototyping tool, I think we should not worry that much as we don't expect production workflows leveraging this directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org