You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/08 07:45:55 UTC
[GitHub] [ozone] bshashikant opened a new pull request #1999: HDDS-4896. Need a tool to upgrade current non-HA SCM node to single node HA cluster
bshashikant opened a new pull request #1999:
URL: https://github.com/apache/ozone/pull/1999
## What changes were proposed in this pull request?
The idea here is to add an optional config "ozone.scm.primordial.node.id". if the config is set, it will cause scm --init to only take effect on
the specific node and ignore scm --bootstrap cmd. Similarly, scm --init will be ignored on the non-primordial scm nodes.
If a cluster is upgraded from non-ratis to ratis based SCM, if the config is set , this will be the primary SCM node which will initialise the ratis
ring.
If the config is not set, scm --init needs to re-run for switching from non-ratis based SCM to ratis-based SCM on the primary node.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4896
## How was this patch tested?
Unit tests added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1999: HDDS-4896. Need a tool to upgrade current non-HA SCM node to single node HA cluster
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1999:
URL: https://github.com/apache/ozone/pull/1999#issuecomment-792719981
How about move `validateRatisGroupExists` to `TestStorageContainerManager`, since it is not used in production code any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #1999: HDDS-4896. Need a tool to upgrade current non-HA SCM node to single node HA cluster
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1999:
URL: https://github.com/apache/ozone/pull/1999#issuecomment-793516921
> One question about the necessity of the optional config `ozone.scm.primordial.node.id`, In which situation will this flag be used ?
>
> With this flag, people can apply init, bootstrap and start on all of the 3 SCMs, so that manual operation will be safer. Is this the requirement ?
yes. This is a requirement for Kubernetes setups .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1999: HDDS-4896. Need a tool to upgrade current non-HA SCM node to single node HA cluster
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1999:
URL: https://github.com/apache/ozone/pull/1999#issuecomment-793556749
> > One question about the necessity of the optional config `ozone.scm.primordial.node.id`, In which situation will this flag be used ?
> > With this flag, people can apply init, bootstrap and start on all of the 3 SCMs, so that manual operation will be safer. Is this the requirement ?
>
> yes. This is a requirement for Kubernetes setups .
Thanks for the explanation. Could you add the explanation for the scenario in comments and ozone-site.xml ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant merged pull request #1999: HDDS-4896. Need a tool to upgrade current non-HA SCM node to single node HA cluster
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1999:
URL: https://github.com/apache/ozone/pull/1999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1999: HDDS-4896. Need a tool to upgrade current non-HA SCM node to single node HA cluster
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1999:
URL: https://github.com/apache/ozone/pull/1999#issuecomment-793835107
+1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng edited a comment on pull request #1999: HDDS-4896. Need a tool to upgrade current non-HA SCM node to single node HA cluster
Posted by GitBox <gi...@apache.org>.
GlenGeng edited a comment on pull request #1999:
URL: https://github.com/apache/ozone/pull/1999#issuecomment-793298119
One question about the necessity of the optional config `ozone.scm.primordial.node.id`, In which situation will this flag be used ?
With this flag, people can apply init, bootstrap and start on all of the 3 SCMs, so that manual operation will be safer. Is this the requirement ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on a change in pull request #1999: HDDS-4896. Need a tool to upgrade current non-HA SCM node to single node HA cluster
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on a change in pull request #1999:
URL: https://github.com/apache/ozone/pull/1999#discussion_r589227956
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServerImpl.java
##########
@@ -103,6 +104,27 @@ public static void initialize(String clusterId, String scmId,
server.close();
}
+ public static void reinitialize(String clusterId, String scmId,
+ SCMNodeDetails details, OzoneConfiguration conf) throws IOException {
+ RaftServer server = newRaftServer(scmId, conf).build();
+ RaftGroup group = null;
+ Iterator<RaftGroup> iter = server.getGroups().iterator();
+ if (iter.hasNext()) {
+ group = iter.next();
+ }
+ // close the server instance so that pending locks on raft storage directory
+ // gets released if any.
+ server.close();
Review comment:
Lets wrap the earlier code in try and do the server close in finally block ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1999: HDDS-4896. Need a tool to upgrade current non-HA SCM node to single node HA cluster
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1999:
URL: https://github.com/apache/ozone/pull/1999#issuecomment-793298119
One question about the optional config `ozone.scm.primordial.node.id`, In which situation will this flag be used ?
With this flag, people can apply init, bootstrap and start on all of the 3 SCMs, so that manual operation will be safer. Is this the requirement ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org