You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/09/23 13:42:57 UTC

[GitHub] [myfaces] volosied commented on a diff in pull request #317: MYFACES-4461: Remove registerCdiProducers checks / Use CDI for implicit objects

volosied commented on code in PR #317:
URL: https://github.com/apache/myfaces/pull/317#discussion_r978687314


##########
impl/src/main/java/org/apache/myfaces/flow/cdi/FlowScopeContext.java:
##########
@@ -244,7 +244,7 @@ public <T> T get(Contextual<T> bean, CreationalContext<T> creationalContext)
         List<String> activeFlowMapKeys = getStorageHolder(facesContext).getActiveFlowMapKeys(facesContext);
         for (String flowMapKey : activeFlowMapKeys)
         {
-            ContextualStorage storage = getContextualStorage(facesContext, false, flowMapKey);
+            ContextualStorage storage = getContextualStorage(facesContext, true, flowMapKey);

Review Comment:
   Atom decided to fix all the whitespace errors. Here's the NPE fix. true  - createIfNotExist



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org