You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "fmannhardt (via GitHub)" <gi...@apache.org> on 2023/04/24 23:51:47 UTC
[GitHub] [superset] fmannhardt opened a new pull request, #23801: fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode
fmannhardt opened a new pull request, #23801:
URL: https://github.com/apache/superset/pull/23801
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
As already indicated in issue #22548 there is a TypeError when using the Handlebars visualization in the raw record mode. This seems to have been caused by adding the columns as an object instead of the expected array. I have simply taken the relevant code from the table plugin and replaced the invalid code with it.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
From #22548:
Local testing after the fix:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
* Load any dataset into a Handlebars chart
* Switch to `raw records` query mode
* Verify that there is no TypeError
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #22548
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23801: fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23801:
URL: https://github.com/apache/superset/pull/23801#issuecomment-1538829505
This PR seems to be stuck on a failing unit test. @fmannhardt I _suspect_ a rebase from `master` might fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23801: fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23801:
URL: https://github.com/apache/superset/pull/23801#issuecomment-1522136086
Thanks for this! Running CI and pinging some additional reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23801: fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23801:
URL: https://github.com/apache/superset/pull/23801#issuecomment-1545023140
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/23801?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23801](https://app.codecov.io/gh/apache/superset/pull/23801?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c29aaca) into [master](https://app.codecov.io/gh/apache/superset/commit/7a55625243e4d405ce27d72ee869cb8e8c785f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a55625) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c29aaca differs from pull request most recent head fc6d026. Consider uploading reports for the commit fc6d026 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23801 +/- ##
=======================================
Coverage 66.54% 66.54%
=======================================
Files 1941 1941
Lines 75280 75279 -1
Branches 8168 8168
=======================================
Hits 50093 50093
+ Misses 23098 23097 -1
Partials 2089 2089
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.52% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/23801?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n-chart-handlebars/src/plugin/controls/columns.tsx](https://app.codecov.io/gh/apache/superset/pull/23801?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvcGx1Z2luL2NvbnRyb2xzL2NvbHVtbnMudHN4) | `15.78% <0.00%> (+0.78%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23801: fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23801:
URL: https://github.com/apache/superset/pull/23801#issuecomment-1538833112
@fmannhardt This seems to be failing repeatedly on unit tests. Could be flaky tests, but I haven't investigated. You might get lucky with a rebase from `master` fixing it (I think there was a problematic one that was fixed) but otherwise you might need to run and debug the tests a bit locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] fmannhardt commented on pull request #23801: fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode
Posted by "fmannhardt (via GitHub)" <gi...@apache.org>.
fmannhardt commented on PR #23801:
URL: https://github.com/apache/superset/pull/23801#issuecomment-1545290190
@rusackas, the rebase seems to have done the trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] fmannhardt commented on pull request #23801: fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode
Posted by "fmannhardt (via GitHub)" <gi...@apache.org>.
fmannhardt commented on PR #23801:
URL: https://github.com/apache/superset/pull/23801#issuecomment-1544417185
I have rebased on current master and pushed the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #23801: fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23801:
URL: https://github.com/apache/superset/pull/23801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org