[GitHub] csantanapr commented on issue #2345: Add the support to install the binaries from the new repo

[gi...@git.apache.org]

csantanapr commented on issue #2345: Add the support to install the binaries from the new repo
URL: https://github.com/apache/incubator-openwhisk/pull/2345#issuecomment-308410151
 
 
   @rabbah 
   >I think this merge is problematic. It created a situation where all the cli tests are in the core repo. So we cannot accept any cli changes because of a circular dependence we can't break easily when cli changes are also required. So for example if there is a cli change and accompanying test changes, the tests in the core repo will be incompatible with the cli version pulled from the cli repo. I think we need to continue building the cli from this local copy until such time when all the accompanying tests are moved to the cli repo.
   
   I agree with further inspecting the other repos.
   I think before we start using the two cli repos we need a better testing story.
   We have two repos to deal with 
   - https://github.com/apache/incubator-openwhisk-client-go
   - https://github.com/apache/incubator-openwhisk-cli
   
   For both there should be tests on the repo, and travis integration that takes the source from the same repo and run tests that are located in the sam repo.
   
   As a transition we should duplicate the tests from core to both, and evaluate which set goes where.
   
   Also provide docs for a contributor on how to setup their dev environment and do testing locally
   
   I proposed we revert this change, and what we can do is introduce a mode for the cli ansible role, where we can pass a flag to do the new behavior to allow experimentation and integration into the other cli repos.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services