You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Ryan Blue (JIRA)" <ji...@apache.org> on 2018/07/18 00:07:00 UTC
[jira] [Commented] (AVRO-1927) If a default value is set, Avro
allows null values in non-nullable fields.
[ https://issues.apache.org/jira/browse/AVRO-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547243#comment-16547243 ]
Ryan Blue commented on AVRO-1927:
---------------------------------
Sounds like the problem here is actually that there is no validation in the avro-specific builders or in object creation. Avro is doing the right thing and not allowing you to serialize invalid data.
I think it makes sense to add null checks to the generated builders. Feel free to fix this and open a PR!
> If a default value is set, Avro allows null values in non-nullable fields.
> --------------------------------------------------------------------------
>
> Key: AVRO-1927
> URL: https://issues.apache.org/jira/browse/AVRO-1927
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.8.1
> Reporter: Andreas Maier
> Priority: Major
>
> With an avro schema like
> {code}
> {
> "name": "myfield",
> "type": "string",
> "default": ""
> }
> {code}
> the following code should throw an exception
> {code}
> MyObject myObject = MyObject.newBuilder().setMyfield(null).build();
> {code}
> But instead the value of myfield is set to null, which causes an exception later when serializing myObject, because null is not a valid value for myfield.
> I believe in this case setMyfield(null) should throw an exception, independent of the value of default.
> See also
> https://stackoverflow.com/questions/38509279/generated-avro-builder-set-null-doesnt-overwrite-with-default
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)