You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/08/27 04:20:04 UTC

[GitHub] [flink] 1996fanrui opened a new pull request, #23303: [FLINK-32847][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests

1996fanrui opened a new pull request, #23303:
URL: https://github.com/apache/flink/pull/23303

   ## What is the purpose of the change
   
   [FLINK-1285](https://issues.apache.org/jira/browse/FLINK-1285) updated the MutableObjectMode to ObjectReuse. The TaskConfig#getMutableObjectMode() is not used for a long long time, and it's internal class, so it can be removed directly.
   
   Also, we should update the GroupReduceDriverTest:
   
   - Updating the testAllReduceDriverAccumulatingImmutable() from `context.setMutableObjectMode(false);` to `context.getExecutionConfig().disableObjectReuse();`.
   - Updating the testAllReduceDriverIncorrectlyAccumulatingMutable() to `context.getExecutionConfig().disableObjectReuse();`, and fix the assert.
   
    
   More details can be get from https://github.com/apache/flink/pull/23233#discussion_r1304595960
   
   
   ## Brief change log
   
   - [FLINK-32847][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests
   - [FLINK-32847][flink-runtime][hotfix] Refactor some code with code style warning
   
   
   ## Verifying this change
   
   Improve the old tests:
   
   - GroupReduceDriverTest#testAllReduceDriverIncorrectlyAccumulatingMutable
   - GroupReduceDriverTest#testAllReduceDriverAccumulatingImmutable
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #23303: [FLINK-32847][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23303:
URL: https://github.com/apache/flink/pull/23303#issuecomment-1694566304

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dbefa1eb105356ddd5123e11fd2cf62426172b33",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dbefa1eb105356ddd5123e11fd2cf62426172b33",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dbefa1eb105356ddd5123e11fd2cf62426172b33 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #23303: [FLINK-32847][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #23303:
URL: https://github.com/apache/flink/pull/23303#issuecomment-1694566042

   Hi @Jiabao-Sun  @RocMarshal  would you mind helping review this PR in your free time? thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui merged pull request #23303: [FLINK-32965][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #23303:
URL: https://github.com/apache/flink/pull/23303


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org