You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2024/02/22 05:24:44 UTC
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21051
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
This patch set the default value of catalog server starting flag
'catalogd_ha_reset_metadata_on_failover' as true so that catalogd
will reset its metadata when it becomes active.
Testing:
- Looped to run unit-tests for catalog HA and statestore HA without
failure.
- Passed core tests
Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
---
M be/src/catalog/catalog-server.cc
M tests/custom_cluster/test_catalogd_ha.py
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/21051/1
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10332/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Feb 2024 22:15:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21051/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21051/2//COMMIT_MSG@9
PS2, Line 9: The standby catalogd may have stale metadata for some reason, like
: event processor could have hung or could be just behind in processing
: events. Also the standby catalogd doesn't get i
> We could expand on the reasoning a bit, maybe:
Updated commit message and added comments in the source code.
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Feb 2024 21:54:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15273/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2024 05:50:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 17:20:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21051/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21051/2//COMMIT_MSG@9
PS2, Line 9: This patch set the default value of catalog server starting flag
: 'catalogd_ha_reset_metadata_on_failover' as true so that catalogd
: will reset its metadata when it becomes active.
We could expand on the reasoning a bit, maybe:
"The passive catalogd may have stale metadata (event processor could have hung or could be just behind in processing events or for some other reason) and also the passive catalog doesn't get invalidate request from coordinator so we should probably reset its metadata when it becomes active."
Probably also good to put a similar comment in the code.
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Feb 2024 20:56:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 18:27:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
The standby catalogd may have stale metadata for some reason, like
event processor could have hung or could be just behind in processing
events. Also the standby catalogd doesn't get invalidate requests from
coordinators so we should probably reset its metadata when it becomes
active to avoid stale metadata.
This patch set the default value of catalog server starting flag
'catalogd_ha_reset_metadata_on_failover' as true so that catalogd
will reset its metadata when it becomes active. Also makes the flag
as hidden option.
Testing:
- Looped to run unit-tests for catalog HA and statestore HA without
failure.
- Passed core tests
Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
---
M be/src/catalog/catalog-server.cc
M tests/custom_cluster/test_catalogd_ha.py
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/21051/3
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
This patch set the default value of catalog server starting flag
'catalogd_ha_reset_metadata_on_failover' as true so that catalogd
will reset its metadata when it becomes active. Also makes the flag
as hidden option.
Testing:
- Looped to run unit-tests for catalog HA and statestore HA without
failure.
- Passed core tests
Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
---
M be/src/catalog/catalog-server.cc
M tests/custom_cluster/test_catalogd_ha.py
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/21051/2
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21051/1/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21051/1/be/src/catalog/catalog-server.cc@155
PS1, Line 155: DEFINE_bool(catalogd_ha_reset_metadata_on_failover, true, "If true, reset all metadata "
There wasn't much of an explanation added for why this is a flag in IMPALA-12513, or why we would want to set it to false. Maybe we should make this a hidden option?
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2024 20:58:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 03:00:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
The standby catalogd may have stale metadata for some reason, like
event processor could have hung or could be just behind in processing
events. Also the standby catalogd doesn't get invalidate requests from
coordinators so we should probably reset its metadata when it becomes
active to avoid stale metadata.
This patch set the default value of catalog server starting flag
'catalogd_ha_reset_metadata_on_failover' as true so that catalogd
will reset its metadata when it becomes active. Also makes the flag
as hidden option.
Testing:
- Looped to run unit-tests for catalog HA and statestore HA without
failure.
- Passed core tests
Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Reviewed-on: http://gerrit.cloudera.org:8080/21051
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Abhishek Rawat <ar...@cloudera.com>
---
M be/src/catalog/catalog-server.cc
M tests/custom_cluster/test_catalogd_ha.py
2 files changed, 10 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Smith: Looks good to me, but someone else must approve
Abhishek Rawat: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2024 20:52:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21051/1/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21051/1/be/src/catalog/catalog-server.cc@155
PS1, Line 155: DEFINE_bool_hidden(catalogd_ha_reset_metadata_on_failover, true, "If true, reset all "
> There wasn't much of an explanation added for why this is a flag in IMPALA-
Makes the flag as hidden option
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2024 23:02:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15345/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2024 23:28:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2024 23:19:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12833: Enabled 'catalogd ha reset metadata on failover' by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15369/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d
Gerrit-Change-Number: 21051
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Feb 2024 22:20:39 +0000
Gerrit-HasComments: No