You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2023/02/14 05:12:33 UTC
[GitHub] [couchdb] nickva commented on a diff in pull request #4422: mango: query planner tests
nickva commented on code in PR #4422:
URL: https://github.com/apache/couchdb/pull/4422#discussion_r1105301298
##########
src/mango/src/mango_cursor_view.erl:
##########
@@ -230,7 +231,13 @@ composite_prefix([Col | Rest], Ranges) ->
% In the future we can look into doing a cached parallel
% reduce view read on each index with the ranges to find
% the one that has the fewest number of rows or something.
-choose_best_index(_DbName, IndexRanges) ->
+-type comparator() :: '$lt' | '$lte' | '$eq' | '$gte' | '$gt'.
+-type range() :: {comparator(), A, comparator(), A} | empty.
Review Comment:
What does `A` mean? If both types are `A`s do we imply they have to match? (I am not very familiar with the type syntax, so may be asking a silly question)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org