[GitHub] [incubator-doris] acelyc111 commented on pull request #5162: [TSAN] Fix tsan bugs (part 1)

[GitBox <gi...@apache.org>]

acelyc111 commented on pull request #5162:
URL: https://github.com/apache/incubator-doris/pull/5162#issuecomment-755842944


   > > @imay I found LLVM has been removed from latest docker image (#2910), but TSAN depends on it (be/src/gutil/atomicops-internals-tsan.h included file `sanitizer/tsan_interface_atomic.h` is generated by LLVM ). So I want to roll LLVM back, how do you think about it?
   > 
   > Do we have another way to handle this? It's a bit heavy to introduce LLVM for this header file.
   
   I‘ve tried to compile GCC manully with sanitizer enabled, but this header still not installed to output dir. I'm not sure if it is a bug of GCC.
   Anyway, now I've updated the code to use sanitizer/tsan_interface_atomic.h as a thirdparty, and remove LLVM dependence, also not needed to upgrade GCC.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org