You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2011/06/13 03:23:52 UTC
[jira] [Created] (SOLR-2589) Commenting out the section in firstSearcher generates an NPE
Commenting out the <arr name="queries"> section in firstSearcher generates an NPE
----------------------------------------------------------------------------------
Key: SOLR-2589
URL: https://issues.apache.org/jira/browse/SOLR-2589
Project: Solr
Issue Type: Bug
Environment: All
Reporter: Erick Erickson
Assignee: Erick Erickson
Priority: Trivial
This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2589) Commenting out the section in firstSearcher generates an NPE
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated SOLR-2589:
---------------------------------
Attachment: SOLR-2589.patch
one-liner, the rest is testing. I'd like to put this up this weekend if possible, my first code check-in!
> Commenting out the <arr name="queries"> section in firstSearcher generates an NPE
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2589
> URL: https://issues.apache.org/jira/browse/SOLR-2589
> Project: Solr
> Issue Type: Bug
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Trivial
> Attachments: SOLR-2589.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2589) Commenting out the section in firstSearcher generates an NPE
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051619#comment-13051619 ]
Erick Erickson commented on SOLR-2589:
--------------------------------------
Forgot to include the issue number in the comment, so it's not showing up here, the revision is r1137092. Here's the ViewVC link: http://svn.apache.org/viewvc?view=revision&revision=r1137092
Thanks Steve for pointing this out.
> Commenting out the <arr name="queries"> section in firstSearcher generates an NPE
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2589
> URL: https://issues.apache.org/jira/browse/SOLR-2589
> Project: Solr
> Issue Type: Bug
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Trivial
> Fix For: 3.3, 4.0
>
> Attachments: SOLR-2589-3x.patch, SOLR-2589.patch, SOLR-2589.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2589) Commenting out the section in firstSearcher generates an NPE
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson resolved SOLR-2589.
----------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.3
updating source momentarily.
> Commenting out the <arr name="queries"> section in firstSearcher generates an NPE
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2589
> URL: https://issues.apache.org/jira/browse/SOLR-2589
> Project: Solr
> Issue Type: Bug
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Trivial
> Fix For: 3.3, 4.0
>
> Attachments: SOLR-2589-3x.patch, SOLR-2589.patch, SOLR-2589.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2589) Commenting out the section in firstSearcher generates an NPE
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051271#comment-13051271 ]
Simon Willnauer commented on SOLR-2589:
---------------------------------------
Erick, good to see testing for this! :)
I wonder if you have an encoding problem I see a <?> in DirectoryFactory (Dir�ctoryFactory) in your patch.
Regarding the one line change I wonder if you could pull the "queries" named list only once, assign it to a local var and check the var for null. Tiny safe but every bit counts.
rest looks good I look forward to more patches like that with more test code than actual changes.
> Commenting out the <arr name="queries"> section in firstSearcher generates an NPE
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2589
> URL: https://issues.apache.org/jira/browse/SOLR-2589
> Project: Solr
> Issue Type: Bug
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Trivial
> Attachments: SOLR-2589.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2589) Commenting out the section in firstSearcher generates an NPE
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated SOLR-2589:
---------------------------------
Attachment: SOLR-2589-3x.patch
SOLR-2589.patch
Turns out that the trunk patch doesn't apply cleanly to the 3x branch, so here are two.
> Commenting out the <arr name="queries"> section in firstSearcher generates an NPE
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2589
> URL: https://issues.apache.org/jira/browse/SOLR-2589
> Project: Solr
> Issue Type: Bug
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Trivial
> Attachments: SOLR-2589-3x.patch, SOLR-2589.patch, SOLR-2589.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2589) Commenting out the section in firstSearcher generates an NPE
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051304#comment-13051304 ]
Simon Willnauer commented on SOLR-2589:
---------------------------------------
bq. Backport to 3x?
yeah thats an easy fix commit to trunk and then merge into 3.x - make sure you read the merge wiki before you merge http://wiki.apache.org/lucene-java/SvnMerge
simon
> Commenting out the <arr name="queries"> section in firstSearcher generates an NPE
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2589
> URL: https://issues.apache.org/jira/browse/SOLR-2589
> Project: Solr
> Issue Type: Bug
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Trivial
> Attachments: SOLR-2589.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2589) Commenting out the section in firstSearcher generates an NPE
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051299#comment-13051299 ]
Erick Erickson commented on SOLR-2589:
--------------------------------------
Ahhh, thanks. I just started using a new machine and think I forgot to
make sure of that.
Yeah, I thought of pulling it out into a variable, but this is rarely
executed code, well, it'd be good for me to do anyway.
Backport to 3x?
Erick
> Commenting out the <arr name="queries"> section in firstSearcher generates an NPE
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2589
> URL: https://issues.apache.org/jira/browse/SOLR-2589
> Project: Solr
> Issue Type: Bug
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Trivial
> Attachments: SOLR-2589.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org