[GitHub] [flink] XComp commented on a change in pull request #18536: [FLINK-25432] Introduces ResourceCleaner to be used in the Dispatcher

[GitBox <gi...@apache.org>]

XComp commented on a change in pull request #18536:
URL: https://github.com/apache/flink/pull/18536#discussion_r793555011



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherFailoverITCase.java
##########
@@ -221,11 +231,11 @@ private TestingDispatcher createRecoveredDispatcher(
             @Nullable FatalErrorHandler fatalErrorHandler) throws Exception {
         final List<JobGraph> jobGraphs = new ArrayList<>();
         for (JobID jobId : haServices.getJobGraphStore().getJobIds()) {
-            jobGraphs.add(haServices.getJobGraphStore().recoverJobGraph(jobId));
+            // there shouldn't be an overlap between dirty JobResults and recovered JobGraphs
+            if (!haServices.getJobResultStore().hasJobResultEntry(jobId)) {
+                jobGraphs.add(haServices.getJobGraphStore().recoverJobGraph(jobId));
+            }
         }
-        // we need to reinstantiate the JobResultStore here to simulate a not-persisting
-        // JobResultStore
-        haServices.setJobResultStore(new EmbeddedJobResultStore());

Review comment:
       FYI: This was the reason the test didn't fail in the previous [FLINK-25430 PR](https://github.com/apache/flink/pull/18189) (`EmbeddedJobResultStore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org