You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 13:05:29 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests

jonkeane commented on a change in pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#discussion_r626546116



##########
File path: dev/archery/archery/tests/test_bot.py
##########
@@ -156,6 +156,7 @@ def handler(command, **kwargs):
 
 @pytest.mark.parametrize(('command', 'reaction'), [
     ('@ursabot build', '+1'),
+    ('@ursabot build\nwith a comment', '+1'),

Review comment:
       Absolutely, I wasn't 100% certain this was the appropriate place to test this — so if it's not let me know.
   
   Also, I expect that test to fail (and respond a -1), though we could probably add support for it if we wanted. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org