[GitHub] [cassandra] aweisberg commented on a diff in pull request #1991: Accord: Transaction Expiration

[GitBox <gi...@apache.org>]

aweisberg commented on code in PR #1991:
URL: https://github.com/apache/cassandra/pull/1991#discussion_r1018181698


##########
src/java/org/apache/cassandra/service/accord/AccordCommandStore.java:
##########
@@ -321,7 +315,7 @@ public long latestEpoch()
     }
 
     @Override
-    public Timestamp maxConflict(Keys keys)
+    public Timestamp preaccept(TxnId txnId, Keys keys)

Review Comment:
   Why does `preaccept` not include the same logic as the implementation in `InMemoryCommandStore` around sometimes returning a new `Timestamp`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org