You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by britter <gi...@git.apache.org> on 2017/08/19 09:45:59 UTC

[GitHub] maven-surefire pull request #162: SUREFIRE-1384: ProviderInfo for JUnit Plat...

GitHub user britter opened a pull request:

    https://github.com/apache/maven-surefire/pull/162

    SUREFIRE-1384: ProviderInfo for JUnit Plattform (WIP)

    Followup for #153 
    
    This is Work in Progress! First take on a JUnitPlattform ProviderInfo, to enable automatic provider lookup.
    
    Need help to get things working :)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/britter/maven-surefire SUREFIRE-1384

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #162
    
----
commit 1a7dd9b84f8462fa841e015826b44c553ff64b5e
Author: Benedikt Ritter <br...@apache.org>
Date:   2017-06-08T12:46:04Z

    SUREFIRE-1384: Start implemeting JUnit Plattform ProviderInfo for automatic
    provider lookup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven-surefire pull request #162: SUREFIRE-1384: ProviderInfo for JUnit Plat...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/maven-surefire/pull/162


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/162
  
    @britter 
    Done. I added enforcer configuration. I hope it will be fine.
    Let me know if you have something to do for me.
    Sometimes I am without internet connection for several days or I am connected a half day or so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/162
  
    @britter 
    Actually the master is on JDK6 and the branch junit5 could be on JDK5 that time we created it.
    Maybe you should fix the enforcer configuration to similar to the one in master.
    Try to delete also folders named `2.19.2-SNAPSHOT` in your local Maven repository additionally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

Posted by Tibor Digana <ti...@googlemail.com>.
I will have a look.

On Mon, Aug 28, 2017 at 8:49 PM, britter <gi...@git.apache.org> wrote:

> Github user britter commented on the issue:
>
>     https://github.com/apache/maven-surefire/pull/162
>
>     @Tibor17 any news on this?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
Cheers
Tibor

[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:

    https://github.com/apache/maven-surefire/pull/162
  
    @Tibor17 any news on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:

    https://github.com/apache/maven-surefire/pull/162
  
    @Tibor17 when I run `mvn compile` I get:
    
    ```
    Restricted to JDK 1.5 yet org.apache.maven.surefire:surefire-api:jar:2.19.2-SNAPSHOT:compile contains org/apache/maven/plugin/surefire/runorder/PrioritizedTest.class targeted to JDK 1.6
    [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message:
    Found Banned Dependency: org.apache.maven.surefire:surefire-api:jar:2.19.2-SNAPSHOT
    ```
    
    Jenkins Build is also red. I don't know how to fix this. Can you help?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/162
  
    Sorry my bad, yes master has enforcer with JDK8 (due to javadoc checks within compile time) however maven.compoler.source/target is 1.6.
    I will have a look in to junit5 branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:

    https://github.com/apache/maven-surefire/pull/162
  
    @Tibor17 for the JUnit Plattform Provider we even need JDK 8! Can you merge Master to junit5 Branch so we have the enforcer fixes? Than I can rebase this PR.
    
    Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org